Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IssueKey type #62526

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Add IssueKey type #62526

merged 2 commits into from
Feb 26, 2024

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Feb 26, 2024

What?

Ensures there's a stricter type for the issues map.

Closes NEXT-2590

@ijjk
Copy link
Member

ijjk commented Feb 26, 2024

Failing test suites

Commit: 87d84f3

pnpm test-dev test/development/basic/barrel-optimization/barrel-optimization.test.ts

  • Skipped in Turbopack > optimizePackageImports > should support MUI
Expand output

● Skipped in Turbopack › optimizePackageImports › should support MUI

expect(received).toBeLessThan(expected)

Expected: < 1500
Received:   1500

  152 |             // Ensure that the number of modules is less than 1500 - otherwise we're
  153 |             // importing the entire library.
> 154 |             expect(parseInt(moduleCount)).toBeLessThan(1500)
      |                                           ^
  155 |           }
  156 |         })
  157 |

  at Object.toBeLessThan (development/basic/barrel-optimization/barrel-optimization.test.ts:154:43)

Read more about building and testing Next.js in contributing.md.

pnpm test-start test/e2e/app-dir/navigation/navigation.test.ts (PPR)

  • app dir - navigation > navigation between pages and app > should not continously initiate a mpa navigation to the same URL when router state changes
Expand output

● app dir - navigation › navigation between pages and app › should not continously initiate a mpa navigation to the same URL when router state changes

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#link-to-slow-page')
  -   locator resolved to visible <a href="/slow-page" id="link-to-slow-page">To /slow-page</a>

  421 |     return this.chain(() => {
  422 |       return page
> 423 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  424 |         .then(async (el) => {
  425 |           // it seems selenium waits longer and tests rely on this behavior
  426 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:423:10)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Feb 26, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-26-Add_IssueKey_type Change
buildDuration 13.9s 13.9s N/A
buildDurationCached 8.4s 6.3s N/A
nodeModulesSize 197 MB 197 MB ⚠️ +198 B
nextStartRea..uration (ms) 428ms 432ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 02-26-Add_IssueKey_type Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 241 B
main-HASH.js gzip 32.1 kB 32.2 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 45.6 kB 45.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 02-26-Add_IssueKey_type Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 02-26-Add_IssueKey_type Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.2 kB 4.2 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.56 kB 6.56 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 02-26-Add_IssueKey_type Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 02-26-Add_IssueKey_type Change
index.html gzip 529 B 526 B N/A
link.html gzip 541 B 539 B N/A
withRouter.html gzip 524 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 02-26-Add_IssueKey_type Change
edge-ssr.js gzip 94.9 kB 94.9 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 02-26-Add_IssueKey_type Change
middleware-b..fest.js gzip 627 B 626 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js 02-26-Add_IssueKey_type Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 96.6 kB 96.6 kB
app-page-tur..prod.js gzip 98.3 kB 98.3 kB
app-page-tur..prod.js gzip 92.8 kB 92.8 kB
app-page.run...dev.js gzip 151 kB 151 kB
app-page.run..prod.js gzip 91.3 kB 91.3 kB
app-route-ex...dev.js gzip 22 kB 22 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.51 kB 9.51 kB
pages-api.ru...dev.js gzip 9.79 kB 9.79 kB
pages-api.ru..prod.js gzip 9.51 kB 9.51 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 23 kB 23 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.5 kB 50.5 kB
Overall change 950 kB 950 kB
build cache
vercel/next.js canary vercel/next.js 02-26-Add_IssueKey_type Change
0.pack gzip 1.56 MB 1.56 MB N/A
index.pack gzip 105 kB 105 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 87d84f3

Base automatically changed from 02-26-Rename_currentIssues_to_currentEntryIssues to canary February 26, 2024 09:43
@timneutkens timneutkens requested a review from a team as a code owner February 26, 2024 09:43
@timneutkens timneutkens merged commit bbf6dfa into canary Feb 26, 2024
62 of 70 checks passed
@timneutkens timneutkens deleted the 02-26-Add_IssueKey_type branch February 26, 2024 13:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants