Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade vendored react #62549

Merged
merged 3 commits into from Feb 26, 2024
Merged

Upgrade vendored react #62549

merged 3 commits into from Feb 26, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 26, 2024 •
edited by padmaia

React upstream changes

Closes NEXT-2600

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 26, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Feb 26, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/react-dom@18.3.0-canary-6c3b8dbfe-20240226 Transitive: environment +4 14.4 MB fb, gnoff, react-bot, ...2 more
npm/react-server-dom-turbopack@0.0.0-experimental-6c3b8dbfe-20240226 Transitive: environment +8 8.15 MB acdlite, gnoff, react-bot
npm/react-server-dom-turbopack@18.3.0-canary-6c3b8dbfe-20240226 Transitive: environment +8 7.89 MB acdlite, gnoff, react-bot
npm/react-server-dom-webpack@0.0.0-experimental-6c3b8dbfe-20240226 Transitive: environment, eval, filesystem, network, shell, unsafe +87 27.5 MB acdlite, brianvaughn, gaearon, ...2 more
npm/react-server-dom-webpack@18.3.0-canary-6c3b8dbfe-20240226 Transitive: environment, eval, filesystem, network, shell, unsafe +87 27.2 MB acdlite, brianvaughn, gaearon, ...2 more
npm/react@0.0.0-experimental-6c3b8dbfe-20240226 Transitive: environment +2 666 kB fb, gnoff, react-bot, ...1 more
npm/react@18.3.0-canary-6c3b8dbfe-20240226 Transitive: environment +2 623 kB fb, gnoff, react-bot, ...1 more
npm/scheduler@0.24.0-canary-6c3b8dbfe-20240226 Transitive: environment +2 235 kB fb, gnoff, react-bot, ...1 more

🚮 Removed packages: npm/react-dom@0.0.0-experimental-a515d753b-20240220, npm/react-dom@18.3.0-canary-a515d753b-20240220, npm/react-server-dom-turbopack@0.0.0-experimental-a515d753b-20240220, npm/react-server-dom-turbopack@18.3.0-canary-a515d753b-20240220, npm/react-server-dom-webpack@0.0.0-experimental-a515d753b-20240220, npm/react-server-dom-webpack@18.3.0-canary-a515d753b-20240220, npm/react@0.0.0-experimental-a515d753b-20240220, npm/react@18.3.0-canary-a515d753b-20240220, npm/scheduler@0.0.0-experimental-a515d753b-20240220, npm/scheduler@0.24.0-canary-a515d753b-20240220

View full report↗︎

@ijjk
Copy link
Member

ijjk commented Feb 26, 2024 •
edited

Tests Passed

@ijjk
Copy link
Member

ijjk commented Feb 26, 2024 •
edited

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js upgrade-react Change
buildDuration 13.8s 13.9s ⚠️ +118ms
buildDurationCached 7.4s 6.3s N/A
nodeModulesSize 197 MB 197 MB ⚠️ +305 kB
nextStartRea..uration (ms) 406ms 405ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js upgrade-react Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB ✓
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 242 B 242 B ✓
main-HASH.js gzip 32.1 kB 32.2 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 99.3 kB 99.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js upgrade-react Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js upgrade-react Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.2 kB 4.2 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.56 kB 6.56 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js upgrade-react Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js upgrade-react Change
index.html gzip 529 B 526 B N/A
link.html gzip 541 B 539 B N/A
withRouter.html gzip 524 B 521 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js upgrade-react Change
edge-ssr.js gzip 95 kB 95 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js upgrade-react Change
middleware-b..fest.js gzip 627 B 623 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 990 B 990 B ✓
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js upgrade-react Change
app-page-exp...dev.js gzip 170 kB 171 kB ⚠️ +1.72 kB
app-page-exp..prod.js gzip 96.6 kB 96.7 kB ⚠️ +116 B
app-page-tur..prod.js gzip 98.3 kB 98.5 kB ⚠️ +138 B
app-page-tur..prod.js gzip 92.8 kB 92.9 kB N/A
app-page.run...dev.js gzip 151 kB 150 kB N/A
app-page.run..prod.js gzip 91.3 kB 91.4 kB N/A
app-route-ex...dev.js gzip 22 kB 21.3 kB N/A
app-route-ex..prod.js gzip 15 kB 15 kB N/A
app-route-tu..prod.js gzip 15 kB 15 kB N/A
app-route-tu..prod.js gzip 14.8 kB 14.8 kB N/A
app-route.ru...dev.js gzip 21.7 kB 20.9 kB N/A
app-route.ru..prod.js gzip 14.8 kB 14.8 kB N/A
pages-api-tu..prod.js gzip 9.51 kB 9.51 kB ✓
pages-api.ru...dev.js gzip 9.79 kB 9.79 kB ✓
pages-api.ru..prod.js gzip 9.51 kB 9.51 kB ✓
pages-turbo...prod.js gzip 22.3 kB 22.3 kB ✓
pages.runtim...dev.js gzip 23 kB 23 kB ✓
pages.runtim..prod.js gzip 22.3 kB 22.3 kB ✓
server.runti..prod.js gzip 50.6 kB 50.6 kB ✓
Overall change 512 kB 514 kB ⚠️ +1.97 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js upgrade-react Change
0.pack gzip 1.56 MB 1.56 MB ⚠️ +682 B
index.pack gzip 104 kB 105 kB ⚠️ +360 B
Overall change 1.66 MB 1.66 MB ⚠️ +1.04 kB
Diff details
Diff for middleware.js

Diff too large to display

Diff for 2453-HASH.js

Diff too large to display

Diff for 3f784ff6-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js 
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Commit: 9e07e50

@huozhi huozhi marked this pull request as ready for review February 26, 2024 17:38
@huozhi huozhi merged commit 87015ac into canary Feb 26, 2024
70 checks passed
@huozhi huozhi deleted the upgrade-react branch February 26, 2024 17:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huozhi @ijjk