feat(turbopack): Sort issues

[kdy1]

What?

Sort issues emitted by turbopack.

Why?

Make it deterministic and testable

How?

Closes PACK-2440

turbopack counterpart: vercel/turbo#7519

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js kdy1/pack-2440	Change
buildDuration	13.8s	13.8s	N/A
buildDurationCached	7.4s	6.6s	N/A
nodeModulesSize	197 MB	197 MB	N/A
nextStartRea..uration (ms)	432ms	433ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js kdy1/pack-2440	Change
2453-HASH.js gzip	30.5 kB	30.5 kB	N/A
3304.HASH.js gzip	181 B	181 B	✓
3f784ff6-HASH.js gzip	53.7 kB	53.7 kB	N/A
8299-HASH.js gzip	5.04 kB	5.04 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	241 B	243 B	N/A
main-HASH.js gzip	32.1 kB	32.2 kB	N/A
webpack-HASH.js gzip	1.7 kB	1.7 kB	N/A
Overall change	45.4 kB	45.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js kdy1/pack-2440	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js kdy1/pack-2440	Change
_app-HASH.js gzip	196 B	197 B	N/A
_error-HASH.js gzip	184 B	184 B	✓
amp-HASH.js gzip	505 B	505 B	✓
css-HASH.js gzip	324 B	325 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	258 B	258 B	✓
head-HASH.js gzip	352 B	352 B	✓
hooks-HASH.js gzip	370 B	371 B	N/A
image-HASH.js gzip	4.2 kB	4.2 kB	✓
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	314 B	312 B	N/A
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	6.56 kB	6.56 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js kdy1/pack-2440	Change
_buildManifest.js gzip	483 B	485 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js kdy1/pack-2440	Change
index.html gzip	528 B	526 B	N/A
link.html gzip	541 B	539 B	N/A
withRouter.html gzip	523 B	522 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js kdy1/pack-2440	Change
edge-ssr.js gzip	95 kB	95 kB	N/A
page.js gzip	3.06 kB	3.06 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js kdy1/pack-2440	Change
middleware-b..fest.js gzip	623 B	625 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	25.5 kB	25.5 kB	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	990 B	990 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js kdy1/pack-2440	Change
app-page-exp...dev.js gzip	171 kB	171 kB	✓
app-page-exp..prod.js gzip	96.7 kB	96.7 kB	✓
app-page-tur..prod.js gzip	98.5 kB	98.5 kB	✓
app-page-tur..prod.js gzip	92.9 kB	92.9 kB	✓
app-page.run...dev.js gzip	150 kB	150 kB	✓
app-page.run..prod.js gzip	91.4 kB	91.4 kB	✓
app-route-ex...dev.js gzip	21.3 kB	21.3 kB	✓
app-route-ex..prod.js gzip	15 kB	15 kB	✓
app-route-tu..prod.js gzip	15 kB	15 kB	✓
app-route-tu..prod.js gzip	14.8 kB	14.8 kB	✓
app-route.ru...dev.js gzip	20.9 kB	20.9 kB	✓
app-route.ru..prod.js gzip	14.8 kB	14.8 kB	✓
pages-api-tu..prod.js gzip	9.51 kB	9.51 kB	✓
pages-api.ru...dev.js gzip	9.79 kB	9.79 kB	✓
pages-api.ru..prod.js gzip	9.51 kB	9.51 kB	✓
pages-turbo...prod.js gzip	22.3 kB	22.3 kB	✓
pages.runtim...dev.js gzip	23 kB	23 kB	✓
pages.runtim..prod.js gzip	22.3 kB	22.3 kB	✓
server.runti..prod.js gzip	50.6 kB	50.6 kB	✓
Overall change	950 kB	950 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js kdy1/pack-2440	Change
0.pack gzip	1.56 MB	1.56 MB	⚠️ +428 B
index.pack gzip	104 kB	105 kB	⚠️ +360 B
Overall change	1.67 MB	1.67 MB	⚠️ +788 B

Diff details

Diff for middleware.js

Diff too large to display

Commit: 0d71594

[ijjk]

Failing test suites

Commit: 0d71594

pnpm test-start test/e2e/app-dir/navigation/navigation.test.ts

• app dir - navigation > query string > should handle unicode search params

Expand output

● app dir - navigation › query string › should handle unicode search params

request.response: Target page, context or browser has been closed

  37 |         const browser = await next.browser('/search-params?name=名')
  38 |         async function requestHandler(req: Request) {
> 39 |           const res = await req.response()
     |                                 ^
  40 |           if (!res) return
  41 |
  42 |           requests.push({

  at response (e2e/app-dir/navigation/navigation.test.ts:39:33)
  at cb (lib/browsers/playwright.ts:234:51)
  at Page.forEach (lib/browsers/playwright.ts:234:35)

Read more about building and testing Next.js in contributing.md.

pnpm test test/integration/create-next-app/index.test.ts

• create next app > should use --example-path over the file path in the GitHub URL

Expand output

● create next app › should use --example-path over the file path in the GitHub URL

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  269 |   })
  270 |
> 271 |   it('should use --example-path over the file path in the GitHub URL', async () => {
      |   ^
  272 |     await useTempDir(async (cwd) => {
  273 |       const projectName = 'github-example-path-2'
  274 |       const res = await run(

  at it (integration/create-next-app/index.test.ts:271:3)
  at Object.describe (integration/create-next-app/index.test.ts:40:1)

Read more about building and testing Next.js in contributing.md.

[ForsakenHarmony]

I think the test failure here is real and caused by the issue sorting

[sokra]

I think the test failure here is real and caused by the issue sorting

That test case was flaky before... So it being consistent is an improvement at least, even while the error message is less useful^^

[ForsakenHarmony]

@sokra it's the wrong error message though afaik, I'd rather disable the test 🤔

I think the ordering of issues might be wrong, a module should report its own Transform issues before Resolve, no?

Still think we should add timestamps to issues, that might actually get us the ordering we're looking for

[ForsakenHarmony]

at the very least, leave the correct snapshot there commented out and add a todo comment

[ForsakenHarmony]

see above

this whole problem is caused by the insistence to continue compiling after errors have occurred

[sokra]

timestamps

timestamps won't work when everything is parallel and might recompute independently.

Anyway, so let's change the ordering so that Resolving is after Analysis