-
Notifications
You must be signed in to change notification settings - Fork 26k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor createInfinitePromise to be re-used unresolveable thenable #62595
Merged
ztanner
merged 1 commit into
canary
from
02-27-refactor_createInfinitePromise_to_be_re-used_unresolveable_thenable
Feb 27, 2024
Merged
refactor createInfinitePromise to be re-used unresolveable thenable #62595
ztanner
merged 1 commit into
canary
from
02-27-refactor_createInfinitePromise_to_be_re-used_unresolveable_thenable
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for middleware.jsDiff too large to display Diff for 2453-HASH.jsDiff too large to display |
ztanner
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim and
wyattjoh
as code owners
February 27, 2024 18:52
acdlite
approved these changes
Feb 27, 2024
ztanner
deleted the
02-27-refactor_createInfinitePromise_to_be_re-used_unresolveable_thenable
branch
February 27, 2024 20:06
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use an infinite promise to indefinitely suspend while waiting for something else to happen (new data from a server response, or an MPA navigation finally resolving).
We don't need to create a new promise every time we do this, and instead can leverage a shared "thenable" that will never actually resolve. The primary motivation for this is that
use
shouldn't be called with a new promise value between renders as described in the RFC.Closes NEXT-2625