Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore fully dynamic requests on server side #62949

Merged
merged 7 commits into from
Mar 11, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 6, 2024

What?

make sure that we don't error for dynamic requests on server side.

It will throw at runtime when using a dynamic request.

Why?

Not all packages are fully bundler compatible, but still work when only using the parts that work. We don't want to block users from using them by having an hard compile error.

How?

Closes PACK-2675

@ijjk ijjk added area: tests Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Mar 6, 2024
@ijjk
Copy link
Member

ijjk commented Mar 6, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js sokra/warn-only-for-dynamic-requests-on-server Change
buildDuration 13.8s 13.8s N/A
buildDurationCached 7.4s 6.3s N/A
nodeModulesSize 198 MB 198 MB
nextStartRea..uration (ms) 438ms 440ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/warn-only-for-dynamic-requests-on-server Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 241 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 45.4 kB 45.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/warn-only-for-dynamic-requests-on-server Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/warn-only-for-dynamic-requests-on-server Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/warn-only-for-dynamic-requests-on-server Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/warn-only-for-dynamic-requests-on-server Change
index.html gzip 528 B 529 B N/A
link.html gzip 539 B 541 B N/A
withRouter.html gzip 523 B 523 B
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/warn-only-for-dynamic-requests-on-server Change
edge-ssr.js gzip 95.1 kB 95.1 kB N/A
page.js gzip 3.06 kB 3.07 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/warn-only-for-dynamic-requests-on-server Change
middleware-b..fest.js gzip 626 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/warn-only-for-dynamic-requests-on-server Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 96.5 kB 96.5 kB
app-page-tur..prod.js gzip 98.3 kB 98.3 kB
app-page-tur..prod.js gzip 92.7 kB 92.7 kB
app-page.run...dev.js gzip 149 kB 149 kB
app-page.run..prod.js gzip 91.2 kB 91.2 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.52 kB 9.52 kB
pages-api.ru...dev.js gzip 9.8 kB 9.8 kB
pages-api.ru..prod.js gzip 9.52 kB 9.52 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 22.9 kB 22.9 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.5 kB 50.5 kB
Overall change 948 kB 948 kB
build cache
vercel/next.js canary vercel/next.js sokra/warn-only-for-dynamic-requests-on-server Change
0.pack gzip 1.56 MB 1.56 MB N/A
index.pack gzip 106 kB 105 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 801b6be

@ijjk
Copy link
Member

ijjk commented Mar 6, 2024

Failing test suites

Commit: eef4762

TURBOPACK=1 pnpm test-dev test/e2e/prerender.test.ts (turbopack)

  • Prerender > should handle fallback only page correctly HTML
Expand output

● Prerender › should handle fallback only page correctly HTML

expect(received).toContain(expected) // indexOf

Expected substring: "hi fallback"
Received string:    "Post: first/post"

  849 |
  850 |       const text = await browser.elementByCss('p').text()
> 851 |       expect(text).toContain('hi fallback')
      |                    ^
  852 |
  853 |       // wait for fallback data to load
  854 |       await check(() => browser.elementByCss('p').text(), /Post/)

  at Object.toContain (e2e/prerender.test.ts:851:20)

Read more about building and testing Next.js in contributing.md.

@sokra sokra force-pushed the sokra/warn-only-for-dynamic-requests-on-server branch from eb2a27f to 42ff9fe Compare March 7, 2024 13:35
@sokra sokra marked this pull request as ready for review March 7, 2024 13:35
Comment on lines 582 to 584
let module_options_context = ModuleOptionsContext {
execution_context: Some(execution_context),
use_lightningcss,
tree_shaking_mode: Some(TreeShakingMode::ReexportsOnly),
import_externals: *next_config.import_externals().await?,
..Default::default()
..module_options_context
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just remove this whole assignment?
same for all the others

@sokra sokra enabled auto-merge (squash) March 7, 2024 16:28
@sokra sokra force-pushed the sokra/warn-only-for-dynamic-requests-on-server branch from 2ed74f1 to d38be30 Compare March 7, 2024 17:01
@sokra sokra merged commit b4b757c into canary Mar 11, 2024
64 of 67 checks passed
@sokra sokra deleted the sokra/warn-only-for-dynamic-requests-on-server branch March 11, 2024 08:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the turbopack team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants