Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with-apollo example uses third party dependency #9676

Closed
dwesty17 opened this issue Dec 9, 2019 · 3 comments
Closed

with-apollo example uses third party dependency #9676

dwesty17 opened this issue Dec 9, 2019 · 3 comments
Labels
good first issue Easy to fix issues, good for newcomers

Comments

@dwesty17
Copy link

dwesty17 commented Dec 9, 2019

Bug report

Describe the bug

The with-apollo example relies on the same 3rd party dependency (graph.cool) that the broken with-apollo-auth was removed for using. Given, this I wanted to ask whether you all would consider a PR that reworked the with-apollo example without the dependency of graph.cool.

Proposed solution

To solve the problem I'd create a mock Apollo server inside of the with-apollo that contained the most basic Apollo server setup. Next to that would be the example Apollo Client that could run against the mock server.

Is this change something you think might be accepted?

@timneutkens timneutkens added good first issue Easy to fix issues, good for newcomers help wanted labels Dec 10, 2019
@dwesty17
Copy link
Author

Cool! I'll take a shot at this sometime this week

@balazsorban44
Copy link
Member

That example does not use graph.cool anymore.

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants