Support unnamed parameters in custom-routes correctly #9920

ijjk · 2020-01-03T14:53:20Z

This makes sure to use the correct index for unnamed parameters in custom-routes since the index starts at 1 for matches on Now but the matches from path-to-regexp start at 0

ijjk · 2020-01-03T14:59:50Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	11.6s	11.9s	⚠️ +295ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +733 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	6.44 kB	6.44 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..6ef5.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js gzip	39.5 kB	39.5 kB	✓
Overall change	69.2 kB	69.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	5.42 kB	5.42 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.6 kB	12.6 kB	✓
framework.HA..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	63.7 kB	63.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.93 kB	2.93 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.89 kB	9.89 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.49 kB	2.49 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.43 kB	7.43 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
index.html gzip	1.04 kB	1.04 kB	✓
link.html gzip	1.04 kB	1.04 kB	✓
withRouter.html gzip	1.03 kB	1.03 kB	✓
Overall change	3.11 kB	3.11 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	12.2s	12.1s	-44ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +733 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	6.44 kB	6.44 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..6ef5.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js gzip	39.5 kB	39.5 kB	✓
Overall change	69.2 kB	69.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	5.42 kB	5.42 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.6 kB	12.6 kB	✓
framework.HA..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	63.7 kB	63.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.93 kB	2.93 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.89 kB	9.89 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.49 kB	2.49 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.43 kB	7.43 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_error.js gzip	78.9 kB	79 kB	⚠️ +93 B
hooks.html gzip	1.07 kB	1.07 kB	✓
index.js gzip	79.1 kB	79.2 kB	⚠️ +90 B
link.js gzip	81.3 kB	81.4 kB	⚠️ +107 B
routerDirect.js gzip	79.2 kB	79.3 kB	⚠️ +88 B
withRouter.js gzip	79.3 kB	79.4 kB	⚠️ +86 B
Overall change	399 kB	399 kB	⚠️ +464 B

Commit: f7f80c5

packages/next/next-server/server/lib/path-match.ts

ijjk · 2020-01-06T17:17:33Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	12s	12s	⚠️ +20ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +1.46 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..4cf7.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.19 kB	4.19 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	12.3s	12.2s	-177ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +1.46 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..4cf7.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.19 kB	4.19 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_error.js gzip	77.8 kB	77.9 kB	⚠️ +170 B
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78.2 kB	⚠️ +167 B
link.js gzip	80.4 kB	80.5 kB	⚠️ +165 B
routerDirect.js gzip	78.1 kB	78.2 kB	⚠️ +170 B
withRouter.js gzip	78.1 kB	78.3 kB	⚠️ +169 B
Overall change	393 kB	394 kB	⚠️ +841 B

Commit: 78ca121

changes

ijjk · 2020-01-06T18:28:58Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	11.9s	12.1s	⚠️ +219ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +1.46 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..4cf7.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.19 kB	4.19 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	12.2s	11.9s	-302ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +1.46 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..4cf7.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.19 kB	4.19 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_error.js gzip	77.8 kB	77.9 kB	⚠️ +170 B
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78.2 kB	⚠️ +167 B
link.js gzip	80.4 kB	80.5 kB	⚠️ +165 B
routerDirect.js gzip	78.1 kB	78.2 kB	⚠️ +170 B
withRouter.js gzip	78.1 kB	78.3 kB	⚠️ +170 B
Overall change	393 kB	394 kB	⚠️ +842 B

Commit: 80497e1

ijjk · 2020-01-06T21:21:04Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	14s	14s	-29ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +1.39 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..4cf7.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.19 kB	4.19 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.01 kB	1.01 kB	✓
Overall change	3.06 kB	3.06 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	14s	14s	-29ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +1.39 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..4cf7.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.19 kB	4.19 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_error.js gzip	77.8 kB	77.9 kB	⚠️ +170 B
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78.1 kB	⚠️ +166 B
link.js gzip	80.3 kB	80.5 kB	⚠️ +165 B
routerDirect.js gzip	78 kB	78.2 kB	⚠️ +170 B
withRouter.js gzip	78.1 kB	78.3 kB	⚠️ +169 B
Overall change	393 kB	394 kB	⚠️ +840 B

Commit: 305885d

ijjk · 2020-01-06T22:34:30Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	12.8s	13.1s	⚠️ +246ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +1.39 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..4cf7.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.19 kB	4.19 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	13.2s	12.9s	-280ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +1.39 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.13 kB	5.13 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..4cf7.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.19 kB	4.19 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_error.js gzip	77.7 kB	77.9 kB	⚠️ +170 B
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78.1 kB	⚠️ +167 B
link.js gzip	80.3 kB	80.5 kB	⚠️ +165 B
routerDirect.js gzip	78 kB	78.2 kB	⚠️ +170 B
withRouter.js gzip	78.1 kB	78.3 kB	⚠️ +170 B
Overall change	393 kB	394 kB	⚠️ +842 B

Commit: 5217f7a

…x/unnamed-matches

ijjk · 2020-01-12T19:30:26Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	14.2s	14.3s	⚠️ +91ms
nodeModulesSize	49 MB	49 MB	⚠️ +1.39 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.18 kB	4.18 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.01 kB	1.01 kB	✓
Overall change	3.06 kB	3.06 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	14.8s	14.7s	-72ms
nodeModulesSize	49 MB	49 MB	⚠️ +1.39 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.18 kB	4.18 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_error.js gzip	77.8 kB	77.9 kB	⚠️ +170 B
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78.1 kB	⚠️ +167 B
link.js gzip	80.4 kB	80.5 kB	⚠️ +166 B
routerDirect.js gzip	78.1 kB	78.2 kB	⚠️ +170 B
withRouter.js gzip	78.1 kB	78.3 kB	⚠️ +169 B
Overall change	393 kB	394 kB	⚠️ +842 B

Commit: 529b8cb

ijjk · 2020-01-16T19:02:45Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	14.2s	14.2s	-34ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +1.39 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..e54b.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.16 kB	4.16 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.01 kB	1.01 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	14.5s	14.8s	⚠️ +227ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +1.39 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..e54b.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.16 kB	4.16 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_error.js gzip	77.8 kB	77.9 kB	⚠️ +170 B
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78.1 kB	⚠️ +168 B
link.js gzip	80.4 kB	80.6 kB	⚠️ +166 B
routerDirect.js gzip	78.1 kB	78.2 kB	⚠️ +169 B
withRouter.js gzip	78.1 kB	78.3 kB	⚠️ +169 B
Overall change	393 kB	394 kB	⚠️ +842 B

Commit: 26a7593

ijjk · 2020-01-16T19:07:36Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	11.5s	11.6s	⚠️ +137ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +1.39 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..e54b.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.16 kB	4.16 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.01 kB	1.01 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	12.2s	11.9s	-271ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +1.39 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..e54b.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.16 kB	4.16 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_error.js gzip	77.8 kB	77.9 kB	⚠️ +170 B
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78.1 kB	⚠️ +168 B
link.js gzip	80.4 kB	80.6 kB	⚠️ +166 B
routerDirect.js gzip	78.1 kB	78.2 kB	⚠️ +169 B
withRouter.js gzip	78.1 kB	78.3 kB	⚠️ +169 B
Overall change	393 kB	394 kB	⚠️ +842 B

Commit: 9585c30

ijjk · 2020-01-16T22:30:43Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	12.8s	12s	-778ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +1.39 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..e54b.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.16 kB	4.16 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.01 kB	1.01 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
buildDuration	13.2s	13.1s	-131ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +1.39 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..e54b.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
main-HASH.module.js gzip	4.16 kB	4.16 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/unnamed-matches	Change
_error.js gzip	77.8 kB	77.9 kB	⚠️ +170 B
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78.1 kB	⚠️ +168 B
link.js gzip	80.4 kB	80.6 kB	⚠️ +166 B
routerDirect.js gzip	78.1 kB	78.2 kB	⚠️ +169 B
withRouter.js gzip	78.1 kB	78.3 kB	⚠️ +169 B
Overall change	393 kB	394 kB	⚠️ +842 B

Commit: c388acd

ijjk added 2 commits January 2, 2020 14:56

Support unnamed parameters in custom-routes correctly

172afb6

Merge remote-tracking branch 'upstream/canary' into fix/unnamed-matches

f7f80c5

ijjk added this to the 9.1.x milestone Jan 3, 2020

ijjk requested review from lfades, Timer and timneutkens as code owners January 3, 2020 14:53

Timer previously requested changes Jan 3, 2020

View reviewed changes

packages/next/next-server/server/lib/path-match.ts Outdated Show resolved Hide resolved

Timer modified the milestones: 9.1.x, 9.2.x Jan 3, 2020

ijjk added 2 commits January 6, 2020 10:48

Merge remote-tracking branch 'upstream/canary' into fix/unnamed-matches

87f7a62

Update unnamed params checking to be strict

78ca121

ijjk requested a review from Timer January 6, 2020 17:19

ijjk added the kind: bug Confirmed bug that is on the backlog label Jan 6, 2020

Merge branch 'canary' into fix/unnamed-matches

80497e1

ijjk added 3 commits January 6, 2020 15:11

Merge remote-tracking branch 'upstream/canary' into fix/unnamed-matches

510605a

Removed un-used regexKeys

0bbb912

Merge remote-tracking branch 'upstream/canary' into fix/unnamed-matches

305885d

Merge branch 'canary' into fix/unnamed-matches

5217f7a

ijjk added 2 commits January 12, 2020 13:23

Merge remote-tracking branch 'upstream/canary' into fix/unnamed-matches

6650448

Merge branch 'fix/unnamed-matches' of github.com:ijjk/next.js into fi…

529b8cb

…x/unnamed-matches

ijjk added 2 commits January 16, 2020 12:55

Merge branch 'canary' into fix/unnamed-matches

26a7593

Update test routes

9585c30

Timer modified the milestones: 9.2.x, 9.2.1 Jan 16, 2020

Timer approved these changes Jan 16, 2020

View reviewed changes

Timer added the ready to land label Jan 16, 2020

Merge branch 'canary' into fix/unnamed-matches

c388acd

Timer merged commit 22e015f into vercel:canary Jan 16, 2020

Timer deleted the fix/unnamed-matches branch January 16, 2020 22:38

This was referenced Feb 18, 2020

[Snyk] Upgrade next from 9.1.2 to 9.2.1 ndom91/newtelco-next-maintenance-mgmt#22

Closed

[Snyk] Upgrade next from 9.1.1 to 9.2.1 tinkerbox/mailyard-spa#10

Open

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support unnamed parameters in custom-routes correctly #9920

Support unnamed parameters in custom-routes correctly #9920

ijjk commented Jan 3, 2020

ijjk commented Jan 3, 2020

ijjk commented Jan 6, 2020

ijjk commented Jan 6, 2020

ijjk commented Jan 6, 2020

ijjk commented Jan 6, 2020

ijjk commented Jan 12, 2020

ijjk commented Jan 16, 2020

ijjk commented Jan 16, 2020

ijjk commented Jan 16, 2020

Support unnamed parameters in custom-routes correctly #9920

Support unnamed parameters in custom-routes correctly #9920

Conversation

ijjk commented Jan 3, 2020

ijjk commented Jan 3, 2020

Stats from current PR

ijjk commented Jan 6, 2020

Stats from current PR

ijjk commented Jan 6, 2020

Stats from current PR

ijjk commented Jan 6, 2020

Stats from current PR

ijjk commented Jan 6, 2020

Stats from current PR

ijjk commented Jan 12, 2020

Stats from current PR

ijjk commented Jan 16, 2020

Stats from current PR

ijjk commented Jan 16, 2020

Stats from current PR

ijjk commented Jan 16, 2020

Stats from current PR