From 82452dcb8649801d4b8029f5576165517ad05a9a Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Wed, 29 Jan 2020 19:12:21 -0600 Subject: [PATCH 1/4] Disable caching for react@next workflow as its not support --- .github/workflows/test_react_next.yml | 48 +++++++++++++++------------ 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/.github/workflows/test_react_next.yml b/.github/workflows/test_react_next.yml index c1f3ce0e09dc77e..48ee1793dc72193 100644 --- a/.github/workflows/test_react_next.yml +++ b/.github/workflows/test_react_next.yml @@ -1,4 +1,6 @@ on: + pull_request: + types: [opened, synchronize] schedule: # * is a special character in YAML so you have to quote this string - cron: '0 0,12 * * *' @@ -6,39 +8,43 @@ on: name: Test react@next jobs: - build: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 + # build: + # runs-on: ubuntu-latest + # steps: + # - uses: actions/checkout@v2 - - run: yarn install --frozen-lockfile --check-files - env: - NEXT_TELEMETRY_DISABLED: 1 + # - run: yarn install --frozen-lockfile --check-files + # env: + # NEXT_TELEMETRY_DISABLED: 1 - - run: yarn upgrade react@next react-dom@next -W --dev + # - run: yarn upgrade react@next react-dom@next -W --dev - - uses: actions/cache@v1 - id: cache-build - with: - path: '.' - key: ${{ github.sha }} + # - uses: actions/cache@v1 + # id: cache-build + # with: + # path: '.' + # key: ${{ github.sha }} testAll: name: Test All runs-on: ubuntu-latest needs: build + env: + NEXT_TELEMETRY_DISABLED: 1 + HEADLESS: true strategy: fail-fast: false matrix: group: [1, 2, 3, 4, 5, 6] steps: - - uses: actions/cache@v1 - id: restore-build - with: - path: '.' - key: ${{ github.sha }} + # - uses: actions/cache@v1 + # id: restore-build + # with: + # path: '.' + # key: ${{ github.sha }} + + - run: yarn install --frozen-lockfile --check-files + + - run: yarn upgrade react@next react-dom@next -W --dev - run: node run-tests.js --timings -g ${{ matrix.group }}/6 -c 3 - env: - NEXT_TELEMETRY_DISABLED: 1 - HEADLESS: true From 3c9a29a18fff59b607491601d30aadae8730be07 Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Wed, 29 Jan 2020 19:15:18 -0600 Subject: [PATCH 2/4] Disable needs build --- .github/workflows/test_react_next.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_react_next.yml b/.github/workflows/test_react_next.yml index 48ee1793dc72193..a4c13dae003a8c9 100644 --- a/.github/workflows/test_react_next.yml +++ b/.github/workflows/test_react_next.yml @@ -28,7 +28,7 @@ jobs: testAll: name: Test All runs-on: ubuntu-latest - needs: build + # needs: build env: NEXT_TELEMETRY_DISABLED: 1 HEADLESS: true From 069e8bf973d447330a12307b4673c50bd6d09319 Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Wed, 29 Jan 2020 19:16:41 -0600 Subject: [PATCH 3/4] Also add checkout step --- .github/workflows/test_react_next.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test_react_next.yml b/.github/workflows/test_react_next.yml index a4c13dae003a8c9..1529512437ad658 100644 --- a/.github/workflows/test_react_next.yml +++ b/.github/workflows/test_react_next.yml @@ -43,6 +43,8 @@ jobs: # path: '.' # key: ${{ github.sha }} + - uses: actions/checkout@v2 + - run: yarn install --frozen-lockfile --check-files - run: yarn upgrade react@next react-dom@next -W --dev From 8fdc09672487c7dbfaf1b18186ad63f2fe1dec46 Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Wed, 29 Jan 2020 19:20:08 -0600 Subject: [PATCH 4/4] Remove running on pull_request from testing --- .github/workflows/test_react_next.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/test_react_next.yml b/.github/workflows/test_react_next.yml index 1529512437ad658..6718973fdeafa6d 100644 --- a/.github/workflows/test_react_next.yml +++ b/.github/workflows/test_react_next.yml @@ -1,6 +1,4 @@ on: - pull_request: - types: [opened, synchronize] schedule: # * is a special character in YAML so you have to quote this string - cron: '0 0,12 * * *'