From ea8b54be931900a75e430e6bf48c5e570d9306fe Mon Sep 17 00:00:00 2001 From: David Eriksson Date: Thu, 31 Dec 2020 09:37:36 +0100 Subject: [PATCH 1/2] Remove upper limit on images.domains.length MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Large sites may have more than 50 external ímage sources, so better remove the limit than setting another arbitrary limit. This will undo part of #18217 --- errors/invalid-images-config.md | 1 - packages/next/next-server/server/config.ts | 6 ------ 2 files changed, 7 deletions(-) diff --git a/errors/invalid-images-config.md b/errors/invalid-images-config.md index c060c62728da..2aa00d4ea756 100644 --- a/errors/invalid-images-config.md +++ b/errors/invalid-images-config.md @@ -15,7 +15,6 @@ module.exports = { deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840], // limit of 25 imageSizes values imageSizes: [16, 32, 48, 64, 96, 128, 256, 384], - // limit of 50 domains values domains: [], path: '/_next/image', // loader can be 'default', 'imgix', 'cloudinary', or 'akamai' diff --git a/packages/next/next-server/server/config.ts b/packages/next/next-server/server/config.ts index 8b8a50b1b147..51efed537021 100644 --- a/packages/next/next-server/server/config.ts +++ b/packages/next/next-server/server/config.ts @@ -249,12 +249,6 @@ function assignDefaults(userConfig: { [key: string]: any }) { ) } - if (images.domains.length > 50) { - throw new Error( - `Specified images.domains exceeds length of 50, received length (${images.domains.length}), please reduce the length of the array to continue.\nSee more info here: https://err.sh/next.js/invalid-images-config` - ) - } - const invalid = images.domains.filter( (d: unknown) => typeof d !== 'string' ) From 86e62be43e2bbd2aa40fa14109799a35f78389b9 Mon Sep 17 00:00:00 2001 From: David Eriksson Date: Thu, 31 Dec 2020 09:44:01 +0100 Subject: [PATCH 2/2] Also remove test case :) --- .../image-optimizer/test/index.test.js | 25 ------------------- 1 file changed, 25 deletions(-) diff --git a/test/integration/image-optimizer/test/index.test.js b/test/integration/image-optimizer/test/index.test.js index 2b095c2d0225..1056e242f2e3 100644 --- a/test/integration/image-optimizer/test/index.test.js +++ b/test/integration/image-optimizer/test/index.test.js @@ -447,31 +447,6 @@ function runTests({ w, isDev, domains }) { describe('Image Optimizer', () => { describe('config checks', () => { - it('should error when domains length exceeds 50', async () => { - await nextConfig.replace( - '{ /* replaceme */ }', - JSON.stringify({ - images: { - domains: new Array(51).fill('google.com'), - }, - }) - ) - let stderr = '' - - app = await launchApp(appDir, await findPort(), { - onStderr(msg) { - stderr += msg || '' - }, - }) - await waitFor(1000) - await killApp(app).catch(() => {}) - await nextConfig.restore() - - expect(stderr).toContain( - 'Specified images.domains exceeds length of 50, received length (51), please reduce the length of the array to continue' - ) - }) - it('should error when sizes length exceeds 25', async () => { await nextConfig.replace( '{ /* replaceme */ }',