From 06cd5dee3a685277d42cd40cf28856b3644dc296 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EC=95=88=EC=9D=80=EA=B2=B0?= Date: Mon, 21 Feb 2022 15:30:28 +0900 Subject: [PATCH 1/3] Add @types/react-dom devDependencies --- packages/create-next-app/create-app.ts | 2 +- test/integration/create-next-app/index.test.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/create-next-app/create-app.ts b/packages/create-next-app/create-app.ts index eb7c0cf14175..7b83b6a0de3e 100644 --- a/packages/create-next-app/create-app.ts +++ b/packages/create-next-app/create-app.ts @@ -235,7 +235,7 @@ export async function createApp({ * TypeScript projects will have type definitions and other devDependencies. */ if (typescript) { - devDependencies.push('typescript', '@types/react', '@types/node') + devDependencies.push('typescript', '@types/react', '@types/node', '@types/react-dom') } /** * Install package.json dependencies if they exist. diff --git a/test/integration/create-next-app/index.test.js b/test/integration/create-next-app/index.test.js index bfa14d5ef451..88207a27bf00 100644 --- a/test/integration/create-next-app/index.test.js +++ b/test/integration/create-next-app/index.test.js @@ -141,6 +141,7 @@ describe('create next app', () => { 'react-dom', ]) expect(Object.keys(pkgJSON.devDependencies)).toEqual([ + '@types/react-dom', '@types/node', '@types/react', 'eslint', From fe28361deb541cb21f1418fafaa70dba1afbaa37 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EC=95=88=EC=9D=80=EA=B2=B0?= Date: Mon, 21 Feb 2022 16:42:07 +0900 Subject: [PATCH 2/3] fix: eslint error --- test/integration/create-next-app/index.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/integration/create-next-app/index.test.js b/test/integration/create-next-app/index.test.js index 88207a27bf00..dccbfc22251b 100644 --- a/test/integration/create-next-app/index.test.js +++ b/test/integration/create-next-app/index.test.js @@ -141,9 +141,9 @@ describe('create next app', () => { 'react-dom', ]) expect(Object.keys(pkgJSON.devDependencies)).toEqual([ - '@types/react-dom', '@types/node', '@types/react', + '@types/react-dom', 'eslint', 'eslint-config-next', 'typescript', From 8184633dcbcc48b14352f5e9684756dc201a7170 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EC=95=88=EC=9D=80=EA=B2=B0?= Date: Mon, 21 Feb 2022 17:04:11 +0900 Subject: [PATCH 3/3] fix: eslint error 2 --- packages/create-next-app/create-app.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/create-next-app/create-app.ts b/packages/create-next-app/create-app.ts index 7b83b6a0de3e..1620ee65a0f7 100644 --- a/packages/create-next-app/create-app.ts +++ b/packages/create-next-app/create-app.ts @@ -235,7 +235,12 @@ export async function createApp({ * TypeScript projects will have type definitions and other devDependencies. */ if (typescript) { - devDependencies.push('typescript', '@types/react', '@types/node', '@types/react-dom') + devDependencies.push( + 'typescript', + '@types/react', + '@types/node', + '@types/react-dom' + ) } /** * Install package.json dependencies if they exist.