Fix caching with processed emitDependency #239
Conversation
Codecov Report
@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 81.28% 81.37% +0.09%
==========================================
Files 13 13
Lines 1480 1498 +18
Branches 546 552 +6
==========================================
+ Hits 1203 1219 +16
Misses 110 110
- Partials 167 169 +2
Continue to review full report at Codecov.
|
ijjk
changed the title
|
|
||
| if (this.processed.has(path)) { | ||
| if (filesToEmit && cacheItem) { | ||
| this.emitDependencyCache.set(path, cacheItem.then(res => { |
There was a problem hiding this comment.
Any reason why you're using cacheItem.then() instead of await cacheItem?
There was a problem hiding this comment.
We need to chain the promise here instead of awaiting it since it can be circular and cause circular awaiting that never resolves.
This updates to the latest version of `@vercel/nft` which includes better shared caching between runs. x-ref: vercel/nft#239 x-ref: vercel/nft#238 x-ref: vercel/nft#237
This updates to the latest version of `@vercel/nft` which includes better shared caching between runs. x-ref: vercel/nft#239 x-ref: vercel/nft#238 x-ref: vercel/nft#237
Follow-up to #238 this ensures we handle caching for processed
emitDependencycalls correctly. This also enables testing of the shared caching against the integration suite as it was previously only being tested against the unit suite.