chore: replace deprecated String.prototype.substr()

[CommanderRoot]

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() or String.prototype.substring() (if the second parameter could be negative) which works similarily but aren't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

[styfle]

Why are some substring and others slice?

[CommanderRoot]

My intend was to copy the behaviour of the current substr()

slice() and substring() behave differently if the second parameter is negative.
Examples

"test".slice(0, -1) == "tes"
"test".substring(0, -1) == ""
"test".substr(0, -1) == ""

Sometimes you want to remove the last x chars in which case slice() is what you want but if the second parameter can be positive or negative it's better to use substring* (if the first param is 0, if not it can depend as well)

[codecov]

Codecov Report

Merging #280 (471640e) into main (435005a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 471640e differs from pull request most recent head 0fcf4ee. Consider uploading reports for the commit 0fcf4ee to get more accurate results

@@           Coverage Diff           @@
##             main     #280   +/-   ##
=======================================
  Coverage   80.65%   80.65%           
=======================================
  Files          13       13           
  Lines        1463     1463           
  Branches      544      544           
=======================================
  Hits         1180     1180           
  Misses        116      116           
  Partials      167      167           

Impacted Files	Coverage Δ
src/analyze.ts	86.58% <100.00%> (ø)
src/node-file-trace.ts	86.69% <100.00%> (ø)
src/resolve-dependency.ts	69.81% <100.00%> (ø)
src/utils/get-package-base.ts	73.33% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more