Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add pixelmatch to special case list #281

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Conversation

Ethan-Arrowood
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood commented Apr 11, 2022

Adds unit and integration tests for the pixelmatch package which requires a special case for including the bin directory to correctly trace the dependency pngjs

Fixes a playwright bug https://github.com/microsoft/playwright/blob/7f513360681d2517caa24d266def9b3a7be4f469/packages/playwright-core/src/utils/comparators.ts#L23-L24

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #281 (1858950) into main (cb5f3f9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   80.65%   80.68%   +0.02%     
==========================================
  Files          13       13              
  Lines        1463     1465       +2     
  Branches      544      545       +1     
==========================================
+ Hits         1180     1182       +2     
  Misses        116      116              
  Partials      167      167              
Impacted Files Coverage Δ
src/utils/special-cases.ts 87.23% <100.00%> (+0.27%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@styfle styfle changed the title add pixelmatch to special case list fix: add pixelmatch to special case list Apr 11, 2022
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle
Copy link
Member

styfle commented Apr 11, 2022

@styfle styfle merged commit 2dfb4fe into main Apr 11, 2022
@styfle styfle deleted the special-case-pixelmatch branch April 11, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants