Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update node prefix tests #287

Merged
merged 2 commits into from
May 18, 2022
Merged

chore: Update node prefix tests #287

merged 2 commits into from
May 18, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 18, 2022

Ensures we have the test with the node: prefix and without, also renames the node prefix fixtures to make it more clear that's what is being tested.

x-ref: #285 (comment)

@ijjk ijjk mentioned this pull request May 18, 2022
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #287 (015487e) into main (42defba) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 015487e differs from pull request most recent head 956198a. Consider uploading reports for the commit 956198a to get more accurate results

@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   80.34%   80.28%   -0.07%     
==========================================
  Files          13       13              
  Lines        1486     1486              
  Branches      555      555              
==========================================
- Hits         1194     1193       -1     
  Misses        122      122              
- Partials      170      171       +1     
Impacted Files Coverage Δ
src/analyze.ts 85.98% <0.00%> (-0.24%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ijjk ijjk marked this pull request as ready for review May 18, 2022 16:26
@ijjk ijjk requested a review from styfle as a code owner May 18, 2022 16:26
@ijjk ijjk added the automerge Automatically merge PR once checks pass label May 18, 2022
@styfle styfle changed the title Update node prefix tests chore: Update node prefix tests May 18, 2022
"package.json",
"test/unit/asset-fs-array-expr-node-require/asset1.txt",
"test/unit/asset-fs-array-expr-node-require/input.js"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking the output.js file was necessary for each test fixture 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still necessary just was renamed https://github.com/vercel/nft/blob/main/test/unit/asset-fs-array-expr-node-prefix/output.js guess it shows as a delete because the content changed more than git expects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, git didn't track it as a rename since the contents changed too much 👍

@kodiakhq kodiakhq bot merged commit a6616ca into main May 18, 2022
@kodiakhq kodiakhq bot deleted the test/node-prefix branch May 18, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants