-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support fs-extra
and graceful-fs
#296
Conversation
Codecov Report
@@ Coverage Diff @@
## main #296 +/- ##
==========================================
+ Coverage 80.44% 80.45% +0.01%
==========================================
Files 13 13
Lines 1488 1489 +1
Branches 555 555
==========================================
+ Hits 1197 1198 +1
Misses 121 121
Partials 170 170
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
fs-extra
fs-extra
and graceful-fs
fs-extra
and graceful-fs
fs-extra
and graceful-fs
fs-extra
and graceful-fs
fs-extra
and graceful-fs
Hmm, I think this is not really testing the correct code. I realized that __dirname already triggers asset emission today. For example, this works: const asset1 = __dirname + "/asset1.txt";
const asset2 = __dirname + "/asset2.json"; |
It might need to be a variation of: const fs = require("fs-extra");
console.log(fs.readFileSync(`${process.cwd()}/asset1.txt`));
console.log(fs.readJsonSync(process.cwd() + "/asset2.json")); I need to wrap up for today, but I can take another look later! |
Side thought: we might also want to support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I confirmed this fails with the current version and this PR fixes it 🎉
fs-extra
as an alias tofs
/node:fs
#293