Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove node-pre-gyp dependency #299

Merged
merged 1 commit into from Jun 28, 2022
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Jun 28, 2022

In a previous PR (#206), support for @mapbox/node-pre-gyp was added and the legacy node-pre-gyp was kept around for backwards compatibility.

However, these packages are currently identical besides changing ES5 to ES6 (var => const) should be backwards compatible and safe to drop node-pre-gyp.

This will remove the deprecation warning:

Please upgrade to @mapbox/node-pre-gyp: the non-scoped node-pre-gyp package is deprecated and only the @mapbox scoped package will recieve updates in the future

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #299 (9cb8ee7) into main (48d684f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   80.44%   80.44%           
=======================================
  Files          13       13           
  Lines        1488     1488           
  Branches      555      555           
=======================================
  Hits         1197     1197           
  Misses        121      121           
  Partials      170      170           
Impacted Files Coverage Δ
src/utils/binary-locators.ts 15.38% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@styfle styfle merged commit e863411 into main Jun 28, 2022
@styfle styfle deleted the remove-legacy-node-pre-gyp branch June 28, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants