Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollback engines to >=16 #383

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix: rollback engines to >=16 #383

merged 1 commit into from
Jan 3, 2024

Conversation

styfle
Copy link
Member

@styfle styfle commented Jan 3, 2024

This is a partial revert of PR #374

It was dropping support for node@16 in CI but it didn't modify target in tsconfig.json, so 16 is still supported.

Furthermore, 16 is going to be supported by Vercel a little longer.

This fixes the warning when installing Vercel CLI using node@16

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@vercel/nft@0.26.1',
npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v16.18.1', npm: '8.19.2' }
npm WARN EBADENGINE }

@styfle styfle requested a review from ijjk as a code owner January 3, 2024 18:01
@styfle styfle enabled auto-merge (squash) January 3, 2024 18:02
@styfle styfle merged commit adda8f4 into main Jan 3, 2024
16 checks passed
@styfle styfle deleted the fix-engines-node16 branch January 3, 2024 18:38
Copy link

github-actions bot commented Jan 3, 2024

🎉 This PR is included in version 0.26.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants