Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed git push causes tag to still be created (and a few other problems) #138

Open
Qix- opened this issue Sep 11, 2018 · 0 comments
Open

Comments

@Qix-
Copy link

Qix- commented Sep 11, 2018

A few things:

  1. release shouldn't be pushing anything. It's dangerous and could potentially break users working on a team. Let the user push things to the remote - you can even verify that the remote has everything up to date using Git; release should be doing that, and nothing more.
  2. The above point requires Support specifying remote #135 - it's vital for any sort of git functionality to work without being overly opinionated.
  3. If release fails to git push (as it is - doing the above points would make this one moot), the tag is still created, which means release is going to act weird if you try to call release again. It completely breaks the workflow and prevents me from using release.
  4. In the event the problem in An argument against the <type> CLI parameter #137 arises, it's too late - the tag has already been created and pushed, and the user now has to revert (ugly) or force-push to master (dangerous) and git push origin :tag (delete the remote tag) - all of which is against all Git best practices. This makes release dangerous if you haven't gone through all of the changes beforehand, which kind of defeats the purpose of this utility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant