Add flag for disabling port switching #579
Conversation
| @@ -370,6 +370,7 @@ const loadConfig = async (cwd, entry, args) => { | |||
| '--no-etag': Boolean, | |||
| '--symlinks': Boolean, | |||
| '--cors': Boolean, | |||
| '--no-port-switching': Boolean, | |||
There was a problem hiding this comment.
Could you add documentation for this?
There was a problem hiding this comment.
I've added it to --help. Would you like to have it added somewhere else as well?
There was a problem hiding this comment.
True, that will probably suffice. Thank you.
leerob
changed the title
|
@leerob Sorry to be commenting on a merged PR, but it seems a shame to open an issue just for this: It looks like there hasn't been a release of the library for a year now - please could you cut one so that we can easily make use of this change via NPM? Thanks! |
|
My mistake, does seem to be non-zero. Thanks for adding this! |
|
Ah interesting, I hadn’t even thought about that to be honest. Non-zero seems more intuitive yeah. I was just reusing the shutting down code that was already in place I believe. So it should behave the same as when an error other than EADDRINUSE is thrown. |
|
This has now been released 👍 |
|
Thanks @leerob, just installed it instead of the commit reference and everything looks good! |
#365