Add support for PFX or PKCS12 encoded certificates #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schemburkar
force-pushed
the
typescript-pfx-support
branch
from
c1bf840
to
8bf73f3
Compare
|
Linked PR is now merged 🎉 Want to merge in those changes and let me know when this is ready for review? |
Add support for PFX or PKCS12 encoded certificates
schemburkar
force-pushed
the
typescript-pfx-support
branch
from
21d6859
to
028f5d4
Compare
|
I have rebased the changes based on the recent PR, @leerob you may please review the PR and let me know feedback/changes. |
gamemaker1
reviewed
Jul 13, 2022
|
Testing has now been added! |
Updated cli snapshot due to change in help test, using vitest -u option
|
@leerob I have updated the cli test snapshot with updated text. Can I start another PR for adding tests specific for PFX certs? This will help get this PR merged while I work on tests. Open to suggestions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional work based on the excellent work in #706 for Typescript.
Added support for PFX or PKCS12 encoded certificates by auto detecting format using options passed for SSL. No additional parameter needed to detect. This continues the work in #508 that was in older JS format
For using PFX certificates use following parameters
--ssl-certThis is the path to the PFX certificate--ssl-pass(Optional) This is the path to the password for PFX certificate.Examples for PFX
For PEM (no change)
This PR should only be merged after #706.
CC: @leerob @gamemaker1