Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Included tests for verifying SSL hosting #720

Merged
merged 8 commits into from Jul 27, 2022

Conversation

schemburkar
Copy link
Contributor

Added tests for SSL hosting with PFX and PEM certificates.

Builds on #708 feature to test new scenarios

------------|---------|----------|---------|---------|---------------------------
File        | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
------------|---------|----------|---------|---------|---------------------------
All files   |    91.5 |    82.27 |   84.21 |    91.5 |
 config.ts  |   88.19 |    73.91 |     100 |   88.19 | 49-52,80-87,89-90,96-98
 http.ts    |   83.72 |    77.77 |      80 |   83.72 | 17-21,36,42
 logger.ts  |    87.5 |      100 |      50 |    87.5 | 9,13
 promise.ts |     100 |      100 |     100 |     100 |
 server.ts  |   94.85 |       85 |     100 |   94.85 | 60-61,104,112,130-133,163
------------|---------|----------|---------|---------|---------------------------

CC: @leerob

Add support for PFX or PKCS12 encoded certificates
 Updated cli snapshot due to change in help test, using vitest -u option
Added tests for SSL hosting with PFX and PEM certificates
@schemburkar
Copy link
Contributor Author

This workflow is awaiting approval from a maintainer in #720

Can the CI be approved so that I can verify if its working on the ubuntu host as well? My dev box is Windows.

@leerob
Copy link
Member

leerob commented Jul 19, 2022

This is awesome - excellent work!

@schemburkar
Copy link
Contributor Author

Since we have GitHub Actions now running smooth, do we want to disconnect CircleCI from this repo?
I still get emails on every commit if there is an active PR.

https://app.circleci.com/pipelines/github/vercel/serve

Let me know if an issue should be raised for the same?

@schemburkar
Copy link
Contributor Author

Thanks @gamemaker1 For the feedback, address all your comments.

@leerob
Copy link
Member

leerob commented Jul 20, 2022

Okay, CircleCI should hopefully be removed now.

@schemburkar
Copy link
Contributor Author

All checks are passing fine, do you have any other feedback for me on this PR? If not, I would say its ready to be merged.

@gamemaker1
Copy link
Contributor

Looks good to me :]

Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@leerob leerob merged commit 0616ce3 into vercel:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants