fix(typescript): es2023 is not valid
#84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethan-Arrowood
approved these changes
Jan 31, 2024
Ethan-Arrowood
requested changes
Jan 31, 2024
|
|
@Ethan-Arrowood Updated accordingly. However, I noticed https://github.com/tsconfig/bases/blob/main/bases/node20.json suggests the |
|
Oh good point. Yeah I guess so. I think something is off with the timing (Node18 specifically) and it confused me. Thanks for contributing this! |
mrmckeb
approved these changes
Feb 1, 2024
mrmckeb
changed the title
es2023 is not valides2023 is not valid
Ethan-Arrowood
approved these changes
Feb 1, 2024
|
Thanks for the PR @mwskwong, and for the review @Ethan-Arrowood! |
|
🎉 This PR is included in version 5.2.0-canary.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
es2023is not a valid value forlibandtarget. I propose usingesnextfor now (which is equivalent toes2023in a sense) and keep monitoring the status, since oncees2023is available,esnextis likely equivalent toes2024by that time.