Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jest/require-top-level-describe #92

Closed
mrmckeb opened this issue Mar 4, 2024 · 2 comments · Fixed by #93
Closed

Remove jest/require-top-level-describe #92

mrmckeb opened this issue Mar 4, 2024 · 2 comments · Fixed by #93
Labels
enhancement New feature or request eslint released on @canary released
Milestone
v6

Comments

@mrmckeb
Copy link
Contributor

mrmckeb commented Mar 4, 2024

We've had feedback that this is not very useful, and creates unnecessary nesting in test files.
@mrmckeb mrmckeb added enhancement New feature or request eslint labels Mar 4, 2024
mrmckeb added a commit that referenced this issue Mar 4, 2024
@mrmckeb
feat(eslint): remove jest/require-top-level-describe
bb56cca 
Closes #92

BREAKING CHANGE: `jest/require-top-level-describe` has been removed.
@mrmckeb mrmckeb mentioned this issue Mar 4, 2024
Merged
@mrmckeb mrmckeb added this to the v6 milestone Mar 4, 2024
@vercel-release-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 5.3.0-canary.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vercel-release-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request eslint released on @canary released
Projects
None yet
Milestone
v6
Development

Successfully merging a pull request may close this issue.

feat(eslint): remove jest/require-top-level-describe vercel/style-guide
2 participants
@mrmckeb @vercel-release-bot