Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[turborepo] Windows VSCode terminal issues with Turbo UI #7808

Open
chris-olszewski opened this issue Mar 21, 2024 · 3 comments · Fixed by #7809
Open

[turborepo] Windows VSCode terminal issues with Turbo UI #7808

chris-olszewski opened this issue Mar 21, 2024 · 3 comments · Fixed by #7809
Assignees
@chris-olszewski
Labels
area: windows Issues specifically reproducing on Windows owned-by: turborepo

Comments

@chris-olszewski
Copy link
Contributor

in my windows vscode terminal, pressing the arrow key moves 2 packages at a time, and pressing enter does nothing

turbo.json.-.Sofi-Site.-.Visual.Studio.Code.-.Insiders.2024-03-21.22-39-35.mp4

also pressing ctrl+c keeps the logs in the same place
image

Originally posted by @imranbarbhuiya in #7802 (comment)
@chris-olszewski chris-olszewski self-assigned this Mar 21, 2024
@chris-olszewski chris-olszewski mentioned this issue Mar 21, 2024
Merged
chris-olszewski added a commit that referenced this issue Mar 21, 2024
@chris-olszewski
fix(ui): avoid dupe key events on windows (#7809)
70a3a4b 
### Description

Fixes #7808

Windows console produces an event for a key press as well as an event
for when the key is released. This caused a single arrow key press to
trigger 2 events. This fix is to ignore release events.

As per `crossterm`
[docs](https://docs.rs/crossterm/latest/crossterm/event/struct.KeyEvent.html#structfield.kind)
> kind:
[KeyEventKind](https://docs.rs/crossterm/latest/crossterm/event/enum.KeyEventKind.html)
Kind of event.
Only set if:
Unix:
[KeyboardEnhancementFlags::REPORT_EVENT_TYPES](https://docs.rs/crossterm/latest/crossterm/event/struct.KeyboardEnhancementFlags.html#associatedconstant.REPORT_EVENT_TYPES)
has been enabled with
[PushKeyboardEnhancementFlags](https://docs.rs/crossterm/latest/crossterm/event/struct.PushKeyboardEnhancementFlags.html).
    Windows: always

### Testing Instructions

Use Turbo UI on a run with at least 3 tasks and verify that arrow keys
now only move a single task.


Closes TURBO-2683

Co-authored-by: Chris Olszewski <Chris Olszewski>
@chris-olszewski
Copy link
Contributor Author

Reopening as PR didn't address the screen not clearing.

@chris-olszewski
Copy link
Contributor Author

@imranbarbhuiya I've been unable to reproduce the final two issues you reported. Can you update to the latest canary and verify the following are still happening?

  • Screen isn't cleared on Ctrl-C press? Are you just pressing Ctrl-C once?
  • Enter doesn't allow for a task to be interacted with: Is the task you're trying to interact with marked with either persistent or interactive?

If both issues are persisting, can you include your Windows build version?

@imranbarbhuiya
Copy link

package.json.-.Sofi-Site.-.Visual.Studio.Code.-.Insiders.2024-03-26.22-18-57.mp4

updated to canary, the arrow and enter issues are fixed now but the ctrl+c issue is still there. And yes I'm pressing ctrl+c only once but it prints ^C^C, also seems like a new issue got introduced. Check the above recording, after running the command, the package names get hidden. But when I press the arrow keys, it reappears.

my windows infos are

Edition	Windows 11 Pro
Version	23H2
Installed on	‎10-‎07-‎2023
OS build	22635.3350
Experience	Windows Feature Experience Pack 1000.22688.1001.0

@mehulkar mehulkar added area: windows Issues specifically reproducing on Windows owned-by: turborepo labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chris-olszewski chris-olszewski

Labels
area: windows Issues specifically reproducing on Windows owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): avoid dupe key events on windows vercel/turbo
3 participants
@mehulkar @chris-olszewski @imranbarbhuiya