From bf24c47c8728fadbb94d1c292c067a1e60410bc3 Mon Sep 17 00:00:00 2001 From: Mehul Kar Date: Thu, 20 Apr 2023 18:12:08 -0700 Subject: [PATCH] always print the url if we have one --- cli/internal/runsummary/run_summary.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cli/internal/runsummary/run_summary.go b/cli/internal/runsummary/run_summary.go index 9f006e53b3997..a297114bd8495 100644 --- a/cli/internal/runsummary/run_summary.go +++ b/cli/internal/runsummary/run_summary.go @@ -175,13 +175,12 @@ func (rsm *Meta) Close(ctx context.Context, exitCode int, workspaceInfos workspa _ = spinner.WaitFor(ctx, record, rsm.ui, "...sending run summary...", 1000*time.Millisecond) }() - // After the spinner is done + // After the spinner is done, print any errors and the url if len(errs) > 0 { rsm.ui.Warn("Errors recording run to Spaces") for _, err := range errs { rsm.ui.Warn(fmt.Sprintf("%v", err)) } - return nil } if url != "" {