Skip to content

[next] Add additional tests for i18n revalidate params #5356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 30, 2020

As noticed in vercel/next.js#18443, when revalidating a prerendered page with the default locale the x-now-route-matches can be incorrect. This adds additional checks to ensure the correct params are generated. These tests will fail until the changes in vercel/next.js#18569 are landed on canary

Unverified

This user has not yet uploaded their public signing key.
@ijjk ijjk requested a review from Timer as a code owner October 30, 2020 23:06
@ijjk ijjk requested review from styfle and timneutkens October 30, 2020 23:06
@timneutkens timneutkens merged commit 16060a7 into master Nov 1, 2020
@timneutkens timneutkens deleted the ijjk/next/more-i18n-revalidate-tests branch November 1, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants