Windows: Doesn't work because of .bin executable issue #613

gyandeeps · 2017-06-01T15:36:15Z

Environment

OS: Windows 7/10
Node: 8
now: latest
CLI: git for windows (2.13)

Steps

Install

npm install now

Run

./node_modules/.bin/now -v

Error

./node_modules/.bin/now: line 1: /../now/download/dist/now: No such file or directory

Findings

Current: node_modules/.bin/now

"$basedir/../now/download/dist/now"   "$@"
exit $?

Expected: node_modules/.bin/now

#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir/node" ]; then
  "$basedir/node"  "$basedir/../now/download/dist/now" "$@"
  ret=$?
else 
  node  "$basedir/../now/download/dist/now" "$@"
  ret=$?
fi
exit $ret

Note: By making this change it fixes the issue

ESLint example

I used ESLint generated code and replaced the file paths.

#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir/node" ]; then
  "$basedir/node"  "$basedir/../eslint/bin/eslint.js" "$@"
  ret=$?
else 
  node  "$basedir/../eslint/bin/eslint.js" "$@"
  ret=$?
fi
exit $ret

Notes/Questions

Really not sure why this is happening, maybe how its packaged?
We at ESLint doesn't do anything special and all this is generated by npm install process.
Sorry if this is duplicate. I did try searching 😄 .

The text was updated successfully, but these errors were encountered:

leo · 2017-06-01T15:46:12Z

@igorklopov

igorklopov · 2017-06-01T17:09:09Z

@gyandeeps why do you use node_modules/.bin/now instead of node_modules/.bin/now.cmd? Do you use Cygwin? Windows prepends extensions like .exe and .cmd once it is going to execute a program. So now files are not executed. Their .exe or .cmd counterparts are executed.

If you delete now.cmd and eslint.cmd from .bin do they stop working? This is a question to get more info about your env.

gyandeeps · 2017-06-01T18:35:01Z

I am not doing anything special, that how npm works on windows.
example if i want to run eslint i do ./node_modules/.bin/eslint.

I deleted eslint.cmd and it still works.

igorklopov · 2017-06-01T18:41:30Z

Well, does node_modules/.bin/now.cmd work?

gyandeeps · 2017-06-01T20:00:39Z

So whenever you execute a package through npm like

{
     "lint": "eslint"
}

npm run lint: will hit the eslint.cmd to execute that. same goes for things which are installed globally.

Initially I installed now globally and ran the command now. that also when i got the same error. I am using git bash on windows. Not sure if that makes a difference or not. But again just changing that file content made everything work regardless on how you call the command.

etoxin · 2017-06-16T00:37:49Z

I am also getting this issue:

OS: Windows 8.1
Node: Using nodist (multiple versions)
now: latest
CLI: hyper w/ cygwin

sylvainlap · 2017-06-22T08:55:17Z

Same issue here.

albertosantini · 2017-06-30T20:13:01Z

Using git bash (on Windows 10) and installing now globally I get the error:

$ now -v
[...cut $USERPROFILE path...]/AppData/Roaming/npm/now: line 1: /node_modules/now/download/dist/now: No such file or directory

$ now.cmd -v
7.1.1

https://docs.npmjs.com/files/package.json#bin

Please make sure that your file(s) referenced in bin starts with #!/usr/bin/env node, otherwise the scripts are started without the node executable!

For npm to create the shim right, as suggested by @gyandeeps, the script defined in the bin property of package.json must have the shebang line #!/usr/bin/env node.

albertosantini · 2017-07-08T04:52:11Z

Any news? 7.2.2 doesn't fix it.

Below the script expected for $USERPROFILE/AppData/Roaming/npm/now:

#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir/node" ]; then
  "$basedir/node"  "$basedir/node_modules/now/download/dist/now" "$@"
  ret=$?
else
  node  "$basedir/node_modules/now/download/dist/now" "$@"
  ret=$?
fi
exit $ret

You can notice there is something wrong in the installation because now script doesn't have executable permissions (in git bash environment).

igorklopov · 2017-07-09T11:15:51Z

npm/cmd-shim#25

leo · 2017-07-11T11:01:05Z

Fixed in #713

* add support of nodejs 0.10 * handle 'incorrect header check' error from gunzip * fix progress bar * use async-retry restart after 'incorrect header check' * fix for #613

subodhpareek18 · 2017-07-18T07:00:39Z

The issue still exists on git bash on windows

albertosantini · 2017-07-18T07:16:18Z

@zusamann I don't think the patch was included in the latest version 7.2.4.

Or do you mean you tested the master and it doesn't work?

subodhpareek18 · 2017-07-18T07:21:14Z

Oh sorry for the confusion, I simply used the latest release and did not build from master.

albertosantini · 2017-07-31T18:57:59Z

7.3.0 works fine. Thanks.

leo · 2017-07-31T20:15:08Z

👌

dbarrett24 · 2017-09-06T20:25:33Z

Getting this issue today on version 8.1.0, Windows 10, using gitbash.

Anybody have a solution? Keep getting No such file or directory.

gyandeeps · 2017-09-06T20:29:10Z

same here... I had to use powershell to make it work...

yunyu · 2017-09-09T13:51:39Z

Same on 8.2.1 with git bash...

albertosantini · 2017-09-09T14:08:55Z

Sigh. 8.2.1 doesn't work.

See also #729.

+ now@8.2.1
updated 1 package in 24.149s
16:02:38 [/c/My/Dev]
$ now -v
/c/Users/xobeci/AppData/Roaming/npm/now: line 1: /node_modules/now/download/dist/now: No such file or directory
16:02:57 [/c/My/Dev]
$

Anyway using now.cmd is ok.

leo · 2017-09-09T14:21:23Z

We haven't tackled Git for Windows yet, but I suppose we should do that, now that so many people are interested in it. @igorklopov?

njc12345 · 2017-09-21T08:46:04Z

now not working on Windows 10 : Git Bash.

Node Version: v8.5.0
NPM Version: v5.4.2

Error: /c/Users//AppData/Roaming/npm/now: line 1: /node_modules/now/download/dist/now: No such file or directory

Content of /c/Users/Nikunj/AppData/Roaming/npm/now

"$basedir/node_modules/now/download/dist/now" "$@"
exit $?

flieks · 2017-09-21T09:54:08Z

i'm getting the same

borekb · 2017-09-26T21:01:14Z

I'm no expert but shouldn't now be a shell script? For example, compare cat now and cat tsc:

$ cat /c/Users/Borek/AppData/Roaming/npm/now
"$basedir/node_modules/now/download/dist/now"   "$@"
exit $?

$ cat /c/Users/Borek/AppData/Roaming/npm/tsc
#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir/node" ]; then
  "$basedir/node"  "$basedir/node_modules/typescript/bin/tsc" "$@"
  ret=$?
else
  node  "$basedir/node_modules/typescript/bin/tsc" "$@"
  ret=$?
fi
exit $ret

I think that's what I've seen in most bootstrap scripts.

varna · 2017-10-11T09:40:26Z

Windows 10, Git Bash
$ now.cmd works

albertosantini · 2017-11-08T19:14:19Z

Sigh again.
Apart a few single releases, like 7.3.0, in 9.0.0-canary.9 there is the issue.

Any news?

leo · 2017-11-13T22:22:49Z

https://twitter.com/zeithq/status/930180257864437760

albertosantini · 2017-11-14T06:31:49Z

@leo are you sure?

Using git bash 2.15.0.windows.1, node 9.1.0 and npm 5.5.1, now is installed locally (and not globally).

$ npm ls now
tobedefined@1.0.0 C:\My\Dev\zzz\tobedefined
`-- now@8.5.1

$ node_modules/.bin/now ls
node_modules/.bin/now: line 1: /../now/download/dist/now: No such file or directory

node_modules/.bin/now.cmd ls works.
If you use now inside a npm script, it works: "deploy": "now deploy --public && now alias".
The installation is fixed (Fails install on Windows #729).

leo · 2017-11-14T08:29:25Z

@albertosantini What command did you use to install it?

albertosantini · 2017-11-14T08:34:48Z

npm install now

leo · 2017-11-14T08:38:15Z

It should be npm install -g now. The -g flag is required for installing packages globally.

albertosantini · 2017-11-14T08:43:01Z

Well... I want to install locally (per project) the package and there should not be any diff in terms of "executable".

At least, I didn't notice any difference using other tools, if they are installed globally or locally.

I don't (cannot) think now doesn't support this use case. :)

* add bench * remove yarn.lock * refactor and extract launcher logic * add entrypoints to bench * Update packages/now-node/src/launcher.ts Co-Authored-By: Steven <steven@ceriously.com>

igorklopov added a commit that referenced this issue Jul 10, 2017

fix for #613

a4d8734

leo closed this as completed Jul 11, 2017

leo pushed a commit that referenced this issue Jul 11, 2017

Support for Node.js 0.10 and Git for Windows (#713)

316d711

* add support of nodejs 0.10 * handle 'incorrect header check' error from gunzip * fix progress bar * use async-retry restart after 'incorrect header check' * fix for #613

leo reopened this Sep 9, 2017

Qix- added the triage label Nov 10, 2017

leo closed this as completed Nov 13, 2017

leo reopened this Nov 14, 2017

leo closed this as completed Nov 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows: Doesn't work because of .bin executable issue #613

Windows: Doesn't work because of .bin executable issue #613

gyandeeps commented Jun 1, 2017 •

edited

leo commented Jun 1, 2017

igorklopov commented Jun 1, 2017 •

edited

gyandeeps commented Jun 1, 2017

igorklopov commented Jun 1, 2017

gyandeeps commented Jun 1, 2017

etoxin commented Jun 16, 2017

sylvainlap commented Jun 22, 2017

albertosantini commented Jun 30, 2017

albertosantini commented Jul 8, 2017

igorklopov commented Jul 9, 2017

leo commented Jul 11, 2017

subodhpareek18 commented Jul 18, 2017

albertosantini commented Jul 18, 2017 •

edited

subodhpareek18 commented Jul 18, 2017

albertosantini commented Jul 31, 2017

leo commented Jul 31, 2017

dbarrett24 commented Sep 6, 2017

gyandeeps commented Sep 6, 2017

yunyu commented Sep 9, 2017

albertosantini commented Sep 9, 2017

leo commented Sep 9, 2017

njc12345 commented Sep 21, 2017 •

edited

flieks commented Sep 21, 2017

borekb commented Sep 26, 2017

varna commented Oct 11, 2017

albertosantini commented Nov 8, 2017

leo commented Nov 13, 2017

albertosantini commented Nov 14, 2017

leo commented Nov 14, 2017

albertosantini commented Nov 14, 2017

leo commented Nov 14, 2017

albertosantini commented Nov 14, 2017

Windows: Doesn't work because of .bin executable issue #613

Windows: Doesn't work because of .bin executable issue #613

Comments

gyandeeps commented Jun 1, 2017 • edited

Environment

Steps

Install

Run

Error

Findings

Current: node_modules/.bin/now

Expected: node_modules/.bin/now

ESLint example

Notes/Questions

leo commented Jun 1, 2017

igorklopov commented Jun 1, 2017 • edited

gyandeeps commented Jun 1, 2017

igorklopov commented Jun 1, 2017

gyandeeps commented Jun 1, 2017

etoxin commented Jun 16, 2017

sylvainlap commented Jun 22, 2017

albertosantini commented Jun 30, 2017

albertosantini commented Jul 8, 2017

igorklopov commented Jul 9, 2017

leo commented Jul 11, 2017

subodhpareek18 commented Jul 18, 2017

albertosantini commented Jul 18, 2017 • edited

subodhpareek18 commented Jul 18, 2017

albertosantini commented Jul 31, 2017

leo commented Jul 31, 2017

dbarrett24 commented Sep 6, 2017

gyandeeps commented Sep 6, 2017

yunyu commented Sep 9, 2017

albertosantini commented Sep 9, 2017

leo commented Sep 9, 2017

njc12345 commented Sep 21, 2017 • edited

flieks commented Sep 21, 2017

borekb commented Sep 26, 2017

varna commented Oct 11, 2017

albertosantini commented Nov 8, 2017

leo commented Nov 13, 2017

albertosantini commented Nov 14, 2017

leo commented Nov 14, 2017

albertosantini commented Nov 14, 2017

leo commented Nov 14, 2017

albertosantini commented Nov 14, 2017

gyandeeps commented Jun 1, 2017 •

edited

igorklopov commented Jun 1, 2017 •

edited

albertosantini commented Jul 18, 2017 •

edited

njc12345 commented Sep 21, 2017 •

edited