feat: refactor types and typescript 4 (#581)

.changeset/stupid-rocks-fry.md

@@ -0,0 +1,10 @@
+---
+'@verdaccio/file-locking': minor
+'@verdaccio/types': minor
+'verdaccio-aws-s3-storage': minor
+'verdaccio-google-cloud': minor
+'@verdaccio/local-storage': minor
+'verdaccio-memory': minor
+---
+
+feat: refactor types and typescript 4

core/file-locking/src/utils.ts

@@ -7,7 +7,7 @@ export const statDir = (name: string): Promise<Error | null> => {
   return new Promise((resolve, reject): void => {
     // test to see if the directory exists
     const dirPath = path.dirname(name);
-    fs.stat(dirPath, function(err, stats) {
+    fs.stat(dirPath, function (err, stats) {
       if (err) {
         return reject(err);
       } else if (!stats.isDirectory()) {
@@ -22,7 +22,7 @@ export const statDir = (name: string): Promise<Error | null> => {
 export const statfile = (name: string): Promise<Error | null> => {
   return new Promise((resolve, reject): void => {
     // test to see if the directory exists
-    fs.stat(name, function(err, stats) {
+    fs.stat(name, function (err, stats) {
       if (err) {
         return reject(err);
       } else if (!stats.isFile()) {
@@ -50,7 +50,7 @@ export const lockfile = (name: string): Promise<unknown> => {
     };
     const lockFileName = `${name}.lock`;
     locker.lock(lockFileName, lockOpts, () => {
-      resolve();
+      resolve(undefined);
     });
   });
 };

core/types/.gitignore

@@ -0,0 +1,2 @@
+docs/
+lib/

core/types/README.md

@@ -1,8 +1,9 @@
-# Typescript types for Verdaccio
+# Typescript types
 
 Typescript definitions for verdaccio plugins and internal code
 
-# Typescript
+## Usage
+
 For usage with the library, the `tsconfig.json` should looks like this.
 
 ```
@@ -29,9 +30,9 @@ For usage with the library, the `tsconfig.json` should looks like this.
 }
 ```
 
-### Imports
+### Example
 
-```
+```typescript
 import type {ILocalData, LocalStorage, Logger, Config} from '@verdaccio/types';
 
  class LocalData implements ILocalData {
@@ -45,4 +46,4 @@ import type {ILocalData, LocalStorage, Logger, Config} from '@verdaccio/types';
 }
 ```
 
-
+#### Plugins