-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement search v1 endpoint #2256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc: @favoyang |
Feedback is welcome (using npm7)
|
It seems just adding the access control #1839 for v1 search. Looks to me now. |
verdacciobot
approved these changes
May 15, 2021
Note: We need to copy this logic to |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
npm search
v1 endpoint support by defaultThe
npm search
is able to use two endpoints, the/-all/
and thev1
. Unfortunately npm 7 dropped/-/all
support and requiresv1
. This PR add support forv1
.npm6
or minor will try to hitv1
and if get404
will fallback to/-/all
endpoint.Check for
allow_access
peer package (if you are using a plugin will ask for every package, even uplinks)The experiment
search
has been removed andv1
is enabled by default.Finish v1 search implementation
Add test
Add missing security layer
Support
/-/all
andv1
at the same timeAdd CLI test
Remove search experiment
Disclaimer
How to use