Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore using local path web logo #2270

Merged
merged 2 commits into from
May 22, 2021
Merged

fix: restore using local path web logo #2270

merged 2 commits into from
May 22, 2021

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented May 22, 2021

After release 5.x the configuration web.config.logo loading a local file is unusable, this PR restore the 4.x behavior, loading a logo from local path and https url.

Additionally add some checks, if the file exist and is readable, otherwise fallback to the original logo and will print a warning in the log in such case.

web:
  title: Verdaccio
  # logo: /home/user/Downloads/vue_logo.png
  # or https (http is not longer valid)
  # logo: https://somedomain/test.png

@juanpicado juanpicado added this to the 5.x milestone May 22, 2021
@juanpicado juanpicado changed the title fix: logo load local web logo fix: restore load local web logo May 22, 2021
@juanpicado juanpicado changed the title fix: restore load local web logo fix: restore using local path web logo May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants