feat: updated smoke tests (#150)

veritem · Apr 9, 2023 · a00f44c · a00f44c
1 parent 903608c
commit a00f44c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/rules/prefer-comparison-matcher.test.ts b/src/rules/prefer-comparison-matcher.test.ts
@@ -18,7 +18,8 @@ describe(RULE_NAME, () => {
 				'expect(a !== "string").toStrictEqual(true)',
 				'expect(5 != a).toBe(true)',
 				'expect(a == "string").toBe(true)',
-				'expect(a == "string").not.toBe(true)'
+				'expect(a == "string").not.toBe(true)',
+				'expect().fail(\'Should not succeed a HTTPS proxy request.\');'
 			],
 			invalid: [
 				{

diff --git a/src/rules/prefer-comparison-matcher.ts b/src/rules/prefer-comparison-matcher.ts
@@ -9,7 +9,7 @@ type MESSAGE_IDS = 'useToBeComparison';
 type Options = []
 
 const isString = (node: TSESTree.Node) => {
-	return isStringNode(node) || node.type === AST_NODE_TYPES.TemplateLiteral
+	return isStringNode(node) || node?.type === AST_NODE_TYPES.TemplateLiteral
 }
 
 const isComparingToString = (expression: TSESTree.BinaryExpression) => {
@@ -82,7 +82,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
 				const { matcher } = vitestFnCall
 				const matcherArg = getFirstMatcherArg(vitestFnCall)
 
-				if (comparison.type !== AST_NODE_TYPES.BinaryExpression ||
+				if (comparison?.type !== AST_NODE_TYPES.BinaryExpression ||
 					isComparingToString(comparison) ||
 					// eslint-disable-next-line no-prototype-builtins
 					!EqualityMatcher.hasOwnProperty(getAccessorValue(matcher)) ||