Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow passing arguments as title #187

Merged
merged 4 commits into from
May 22, 2023
Merged

feat: allow passing arguments as title #187

merged 4 commits into from
May 22, 2023

Conversation

so1ve
Copy link
Contributor

@so1ve so1ve commented May 22, 2023

Fixes #183

@veritem
Copy link
Owner

veritem commented May 22, 2023 •
edited

is there anyway we can validate that argument? Since the whole point of this rule is to enforce validity of title, may be in the next PR 🤷‍♀️. Thanks for this one.

@veritem veritem merged commit 6d6e797 into veritem:main May 22, 2023
@so1ve
Copy link
Contributor Author

so1ve commented May 22, 2023

is there anyway we can validate that argument? Since the whole point of this rule is to enforce validity of title, may be in the next PR 🤷‍♀️. Thanks for this one.

Yes I think it is possible - however, it may introduce more complexity. FYI I have made a small function to implement this in https://github.com/so1ve/unplugin-vue-auto-props/blob/main/src/core/utils.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veritem veritem veritem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow passing arguments as test title
2 participants
@so1ve @veritem