Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a smaller error range for no-disabled-tests, just like for no-focused-tests #270

Closed
lydell opened this issue Oct 15, 2023 · 1 comment · Fixed by #278
Closed

Use a smaller error range for no-disabled-tests, just like for no-focused-tests #270

lydell opened this issue Oct 15, 2023 · 1 comment · Fixed by #278

Comments

@lydell
Copy link
Contributor

lydell commented Oct 15, 2023

no-disabled-tests is very noisy because it underlines so much code:

image

no-focused-tests is much nicer:

image
@veritem
Copy link
Owner

veritem commented Oct 22, 2023

a pr is welcome!

lydell added a commit to lydell/eslint-plugin-vitest that referenced this issue Oct 22, 2023
@lydell
feat(no-disabled-tests): make error ranges smaller
1ef11ca 
Fixes veritem#270.
@lydell lydell mentioned this issue Oct 22, 2023
Merged
veritem added a commit that referenced this issue Oct 22, 2023
@lydell @veritem
feat(no-disabled-tests): make error ranges smaller (#278)
8793664 
* test(no-disabled-tests): add failing tests for error ranges

* feat(no-disabled-tests): make error ranges smaller

Fixes #270.

* feat: updated format

---------

Co-authored-by: Verite Mugabo <mugaboverite@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(no-disabled-tests): make error ranges smaller lydell/eslint-plugin-vitest
2 participants
@lydell @veritem