feat(valid-function-names): updated list of possible permutations of call chains #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veritem
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the list of all possible call chains with all possible permutations up to 3 levels deep. I added
benchas per the docs. I also removed Jest-like calls that are not supported by Vitest, likefit,xit,xdescribe, andfdescribe.Because the list has grown quite a bunch, I moved it into its own separate file.
I also cherry picked a few chains to add to your tests. I only added a few since the tests already didn't cover every single possibility.
FYI: I used a script to create the list. See https://gist.github.com/KoenBrouwer/e1df9ff68d0a3fc2d98f34a1d23f41a6.
Fixes #275