expect-expect fails even if expectTypeOf is present

[mrmckeb]

This may be intentional, but we have some tests that only check types and these are being flagged for failing to include expect statements.

[mrmckeb]

I should note that I'm happy to make a PR for this if you want the help!

[veritem]

@mrmckeb a pr is always welcome :D

[mrmckeb]

So thinking about this, and these checks don't actually run unless Vitest is run with --typecheck or the typecheck config option is set.

Perhaps a rule is also required that warns you if you're using these assertions, but haven't enabled that option in your config?

[veritem]

I should have included the edge case for types when designing the rule that is my bad. What you'll have todo for this pr is to check if expectTypeOf exists in test body and return, exiting the rule.

[mrmckeb]

Understood, thanks! I have a bit of rule-writing experience so that should be fine 🤞

My concern was more, should this be the default behaviour? If you don't have typecheck enabled in your config, then this is the same as having no expects at all.
https://vitest.dev/api/expect-typeof

I can consider that in the work I do though, thanks! :)

[veritem]

Definitely, look into a way of knowing whether --typecheck has been enabled and then enable the condition.

[mrmckeb]

Done! Thanks again.