Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering commits does not work when using mouse with autocomplete #1443

Open
pavelevap opened this issue May 10, 2019 · 0 comments
Open

Filtering commits does not work when using mouse with autocomplete #1443

pavelevap opened this issue May 10, 2019 · 0 comments
Labels
bug Bugs. For major ones, add "major". scope: frontend The 'frontend' React app and other UI things

Comments

@pavelevap
Copy link
Collaborator

Steps to reproduce:

  1. Click into "Search" field on VersionPress admin page, autocomplete popup appears.
  2. Select Modifiers - action, then "post/update" (use only mouse).
  3. Click "Search" button (or you can use Enter on keyboard).

Commits are not filtered, XHR request: wp-json/versionpress/commits?1557497758499&page=0&query=

When you follow same steps only with keyboard, especially selecting values from autocomplete list (with arrow keys and Enter), everything works well, XHR request: wp-json/versionpress/commits?1557498071657&page=0&query=action%253Apost%252Fupdate%2520

When there are no commits to show, status 500 should appear?

@pavelevap pavelevap added bug Bugs. For major ones, add "major". scope: frontend The 'frontend' React app and other UI things labels May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs. For major ones, add "major". scope: frontend The 'frontend' React app and other UI things
Projects
None yet
Development

No branches or pull requests

1 participant