Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about removing Handler<AsyncResult<T>> from Future to migration guide. #59

Open
LuboViluda opened this issue Jan 2, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@LuboViluda
Copy link

Describe the feature

  • Add a note about the change to the migration guide.
  • Remove misleading part: "Future extends Handler<AsyncResult> for some time now (and the default implementation actually returns this)." source, which is no longer valid as Future doesn't extend Handler<AsyncResult now.

Vert.x Future extends Handler<AsyncResult>
Vert.x 3.9

Vert.x Future doesn't extend Handler<AsyncResult> in Vert.x 4.0
Vert.x 4.0

As the handle(AsyncResult asyncResult) method is missing this is a potentially breaking change.

Use cases

  • users of Vert.x are prompted about potentially breaking change.
@LuboViluda LuboViluda added the enhancement New feature or request label Jan 2, 2021
@vietj vietj added this to the 1.0.1 milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants