Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new OAuth2AuthorizationURL in OAuth2AuthHandler.extraParams #2602

Open
fbuetler opened this issue Apr 30, 2024 · 0 comments
Open

Use the new OAuth2AuthorizationURL in OAuth2AuthHandler.extraParams #2602

fbuetler opened this issue Apr 30, 2024 · 0 comments
Labels

Comments

@fbuetler
Copy link
Contributor

Version

4.5.7

Context

With the deprecation of String OAuth2Auth.authorizeURL(JsonObject params) and the hint to rather use String OAuth2Auth.authorizeURL(OAuth2AuthorizationURL url), the OAuth2AuthHandler OAuth2AuthHandler.extraParams(JsonObject extraParams) should also prefer the new type instead of accepting a JsonObject as they are closely related and for improved type safety.

https://github.com/eclipse-vertx/vertx-auth/blob/6d63ba27e779810b8ebd5af3c59d9d77fd6037dd/vertx-auth-oauth2/src/main/java/io/vertx/ext/auth/oauth2/OAuth2Auth.java#L131-L153

/**
* Extra parameters needed to be passed while requesting a token.
*
* @param extraParams extra optional parameters.
* @return self
*/
@Fluent
OAuth2AuthHandler extraParams(JsonObject extraParams);

@fbuetler fbuetler added the bug label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant