You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently there exists some complicated dependencies between some setup bash scripts, like the figure shown below:
Actually, most of them have been rewritten with Go, but to remove them completely, some modifications of files under scripts/github_runner directory need to be applied
FYI, below are lists of bash scripts which have been rewritten and should have been removed if dependency issues were fixed:
scripts/setup_system.sh
scripts/setup_gvisor_containerd.sh
scripts/install_go.sh
scripts/setup_firecracker_containerd.sh
scripts/install_stock.sh
scripts/install_pmutools.sh
scripts/setup_node.sh
The text was updated successfully, but these errors were encountered:
can you be more specific on what was rewritten and what wasn't?
Yeah,
Scripts have been rewritten:
All scripts under scripts/cloudlab
All scripts under scripts/cluster
All scripts under scripts/ except clean_cri_runner.sh, create_devmapper.sh, and clean_fcctr.sh
Additionally, scripts/github_runner/setup_cri_test_env.sh has been adapted to use Go scripts
All other scripts under scripts and its sub-directories left untouched
can you please update the PR's description and enumerate the scripts that still need to be eliminated. this issue is not about what was already rewritten but what needs to.
Currently there exists some complicated dependencies between some setup bash scripts, like the figure shown below:
Actually, most of them have been rewritten with Go, but to remove them completely, some modifications of files under
scripts/github_runner
directory need to be appliedFYI, below are lists of bash scripts which have been rewritten and should have been removed if dependency issues were fixed:
scripts/setup_system.sh
scripts/setup_gvisor_containerd.sh
scripts/install_go.sh
scripts/setup_firecracker_containerd.sh
scripts/install_stock.sh
scripts/install_pmutools.sh
scripts/setup_node.sh
The text was updated successfully, but these errors were encountered: