Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate bash scripts dependencies #835

Open
flyinghorse0510 opened this issue Oct 2, 2023 · 3 comments
Open

Eliminate bash scripts dependencies #835

flyinghorse0510 opened this issue Oct 2, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@flyinghorse0510
Copy link
Contributor

flyinghorse0510 commented Oct 2, 2023

Currently there exists some complicated dependencies between some setup bash scripts, like the figure shown below:

Screenshot 2023-10-03 at 01 39 03

Actually, most of them have been rewritten with Go, but to remove them completely, some modifications of files under scripts/github_runner directory need to be applied

FYI, below are lists of bash scripts which have been rewritten and should have been removed if dependency issues were fixed:

  • scripts/setup_system.sh
  • scripts/setup_gvisor_containerd.sh
  • scripts/install_go.sh
  • scripts/setup_firecracker_containerd.sh
  • scripts/install_stock.sh
  • scripts/install_pmutools.sh
  • scripts/setup_node.sh
@ustiugov
Copy link
Member

ustiugov commented Oct 3, 2023

can you be more specific on what was rewritten and what wasn't?

@flyinghorse0510
Copy link
Contributor Author

can you be more specific on what was rewritten and what wasn't?

Yeah,
Scripts have been rewritten:
All scripts under scripts/cloudlab
All scripts under scripts/cluster
All scripts under scripts/ except clean_cri_runner.sh, create_devmapper.sh, and clean_fcctr.sh
Additionally, scripts/github_runner/setup_cri_test_env.sh has been adapted to use Go scripts

All other scripts under scripts and its sub-directories left untouched

@ustiugov
Copy link
Member

ustiugov commented Oct 3, 2023

can you please update the PR's description and enumerate the scripts that still need to be eliminated. this issue is not about what was already rewritten but what needs to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants