Update light build targets to include Typescript extensions

[itsjamie]

This fixes an issue where light-dist / light defined their own resolve property causing them to not get the base config resolve for extensions, etc.

Includes a few minor lint fixes that popped in my editor as well.

Before:

After:

• changes have been done against master branch, and PR does not conflict

[itsjamie]

@tchakabam I think you've worked a lot on this, do you see any issues with this change? What prompted me looking was the build failures on light and light-dist when I added a typescript file without the extension for buffer-controller.

[itsjamie]

Link #2070

[tjenkinson]

Looks good to me

[johnBartos]

Should we just use webpack-merge? https://github.com/survivejs/webpack-merge

It's called out in the official webpack docs https://webpack.js.org/guides/production/

[tjenkinson]

@johnBartos that package looks nice but brings in more dependencies, and what is here now is essentially the same thing ¯_(ツ)_/¯

[johnBartos]

True. We could also be more minimal and just add the extensions array to the returned value of getAliasesForLightDist

[itsjamie]

I'm all for the smallest change possible that fixes the issue. I reverted the deep-merge in favour of simply defining the extensions array on the two light targets.

My 2c would be if continues to be an issue going forwarded to maintain the simple approach, webpack-merge library seems to be a good option. It does seem to do some nice things with regards to loaders etc that wouldn't make sense to write again. Thanks @johnBartos @tjenkinson.

[tjenkinson]

I actually would prefer a more generic solution (previous commit or merge lib) over this one off fix, but this works

[michaelcunningham19]

👍

[itsjamie]

Squashed history down to just the generic webpack-merge implementation. It does do some good things where it will deep-merge loader arrays, and is the webpack approved solution for this problem, so I went with that.

Thanks everyone.

[michaelcunningham19]

Merging to unblock #2073 and #2076

Travis CI shows the webpack build succeeds without file resolution errors