Converting binary search helper to TS #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjenkinson
reviewed
Feb 13, 2019
| @@ -0,0 +1,44 @@ | |||
| type BinarySearchComparison < T > = (candidate: T) => -1 | 0 | 1; | |||
There was a problem hiding this comment.
Nit: <T>
Also we should export type this. Generally anything that is used on the public path should be exported
There was a problem hiding this comment.
👍
If I remember correctly, changing < T > to <T> resulted in this eslint error: https://eslint.org/docs/rules/space-infix-ops
I'd hate to suppress that eslint rule though, as it should error/warn in the case of const sum = 1+ 2 shouldn't it?
There was a problem hiding this comment.
Ah if it's a lint thing then fine as long as it is consistent everywhere :)
johnBartos
approved these changes
Feb 13, 2019
|
I think the type should still be exported from the file though
On 13 Feb 2019, at 18:18, John Bartos <notifications@github.com<mailto:notifications@github.com>> wrote:
Merged #2129<#2129> into master.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#2129 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADG-WTZqZFvtP7oW5cpm0Ls6gJVSRR3Bks5vNEj3gaJpZM4a4YPa>.
|
dyue
added a commit
to dyue/hls.js
that referenced
this pull request
Mar 9, 2019
* origin/master: (59 commits) Change networkDetails type to "unknown". mp4-remuxer / remuxAudio() : recompute mdatSize / dont rely on audioTrack.len (video-dev#2096) Typo fix for destory -> destroy. Change responseType to string Callbacks are defined, removing TODO. video-devGH-2082: Replacing usage of Array.prototype.find/findIndex (video-dev#2117) Reduce GC pressure from ID3._utf8ArrayToStr (video-dev#2035) (misc): converting binary search to typescript (video-dev#2129) (misc) Removing IE8-specific (dead) vtt/cue code Fixed case of 'They use hls.js in production!' header and updated Viacom image link to new domain and using https (video-dev#2127) remove events/EventEmitter && move Observer to ts (video-dev#2097) Basic typescript of event handler. Update webpack to use babel loader with support for TS. (video-dev#2119) Allow console statement in test bench and saucelabs code. Lint fixes Playlist Loader conversion to TypeScript. Playlist-loader rename. Change IV handling for initSegments to just log a warning. Add handling for AES-128 encrypted initialization segments needing IV. (misc) Adding ace editor to demo to enable advanced customization (video-dev#2077) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
... convert our binary search helper to TypeScript
Why is this Pull Request needed?
Part of the on-going effort to introduce TypeScript to the project
Are there any points in the code the reviewer needs to double check?
The added function signature for
BinarySearchComparison- thoughts on the return type/value enforcement? Was thinking simplynumberwould suffice.As well, the parameter
Twas added as it makes working with thesearchfunction nicer looking IMO, example:Resolves issues:
None in particular
Checklist
[ ] new unit / functional tests have been added (whenever applicable)N/A[ ] API or design changes are documented in API.mdN/A