Basic typescript of event handler. #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
This adds simple type definitions to the event handler base class. This makes it so all classes that expand upon this base class can be typed before having to go through and type all the event data.
Why is this Pull Request needed?
npm run type-checkfails without asthis.hlsis undefined for any classes that extend.Are there any points in the code the reviewer needs to double check?
Don't worry too much about the
anytypes here. These will be piece-mealed out for better definitions as the events class becomes incrementally more typed.Resolves issues:
Checklist