load audio playlist on MANIFEST_PARSED #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsjamie
requested changes
Aug 18, 2019
itsjamie
previously approved these changes
Sep 9, 2019
|
Changes I requested were made for the unit tests. Not waiting until level playlist is loaded to load alternative audio groups (not in the video track) makes all kinds of sense to me but would like another opinion. |
robwalch
previously requested changes
Oct 3, 2019
…d-audio-after-manifest-parsed
mad-gooze
force-pushed
the
load-audio-after-manifest-parsed
branch
from
34a16e2
to
3c94a82
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@mad-gooze will you have time to look into the comments @robwalch raised? It seems like a nice performance boost we should add. |
robwalch
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
start loading level playlist on MANIFEST_PARSED event so audio will be loaded earlier
Why is this Pull Request needed?
Now hls.js starts fetching audio playlist after loading level playlist, so video start on streams with separate audio track is delayed
With the proposed change audio playlist will be loaded after MANIFEST_PARSED
With the proposed change video will start faster.
This can be tested here.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist
API or design changes are documented in API.md