Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextTrack doesn't show up on LG SDK2 #2400

Closed
Yuvalke opened this issue Oct 13, 2019 · 0 comments · Fixed by #2431 · May be fixed by tjenkinson/flowplayer-hlsjs#2
Closed

TextTrack doesn't show up on LG SDK2 #2400

Yuvalke opened this issue Oct 13, 2019 · 0 comments · Fixed by #2431 · May be fixed by tjenkinson/flowplayer-hlsjs#2

Comments

@Yuvalke
Copy link
Contributor

Yuvalke commented Oct 13, 2019

Is your feature request related to a problem? Please describe.
LG SDK2 TextTrack didn't show up - addCue method has a bug in LG SDK 2, the method wasn't throw an exception when cue structure is invalid.

Describe the solution you'd like
Add check if cues doesn't inserted and try the fallback structure TextTrackCue.

Yuvalke added a commit to Yuvalke/hls.js that referenced this issue Oct 13, 2019
… addCue method

add new configuration forceTextTrackCue to enable captions on problematic OS such as LG SDK 2, which has bug on their addCue method with different structure it won't add caption at all.
Yuvalke added a commit to Yuvalke/hls.js that referenced this issue Oct 13, 2019
… addCue method

add new configuration forceTextTrackCue to enable captions on problematic OS such as LG SDK 2, which has bug on their addCue method with different structure it won't add caption at all.
Yuvalke added a commit to Yuvalke/hls.js that referenced this issue Oct 30, 2019
fix video-dev#2400 throw error when the added cue isn't exist anymore
@Yuvalke Yuvalke changed the title Add configuration to force usage in TextTrackCue. Add check if cues doesn't inserted and try the fallback structure TextTrackCue. Oct 30, 2019
@Yuvalke Yuvalke changed the title Add check if cues doesn't inserted and try the fallback structure TextTrackCue. TextTrack didn't show up on LG SDK2 Oct 30, 2019
@Yuvalke Yuvalke changed the title TextTrack didn't show up on LG SDK2 TextTrack doesn't show up on LG SDK2 Oct 30, 2019
robwalch added a commit that referenced this issue Dec 12, 2019
fix #2400 issue - cues doesn't show up on browsers which addCue doesn't throw error with invalid structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment