Remove TypeScript types build step #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so until we are ready to flip the switch on adding types, there won't be conflicting Typescript definitions for users that are using `@types/hls.js`.
robwalch
previously approved these changes
Dec 17, 2019
tjenkinson
previously requested changes
Dec 17, 2019
itsjamie
dismissed
tjenkinson’s stale review
Removed from the noted section.
tjenkinson
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
This makes it so until we are ready to flip the switch on adding types, there won't be conflicting Typescript definitions for users that are using
@types/hls.js.Why is this Pull Request needed?
Currently, the types even without a type root are being found by various language servers, and confusing typecheckers with projects that pull in the DefinitelyTyped version of hls.js
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Closes #2474
Checklist