Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReferenceError: Can't find variable: SourceBuffer on SamsungTV #2476

Closed
5 tasks done
riadasllani opened this issue Dec 18, 2019 · 10 comments · Fixed by #2490
Closed
5 tasks done

ReferenceError: Can't find variable: SourceBuffer on SamsungTV #2476

riadasllani opened this issue Dec 18, 2019 · 10 comments · Fixed by #2490
Labels
Bug Duplicate
Milestone
0.13.1

Comments

@riadasllani
Copy link

riadasllani commented Dec 18, 2019 •
edited

What version of Hls.js are you using?

v0.13.0

What browser and OS are you using?

Samsung TV - TizenOS

Test stream:

N/A

Checklist

  • The stream has correct Access-Control-Allow-Origin headers (CORS)
  • There are no network errors such as 404s in the browser console when trying to play the stream

Steps to reproduce

  1. Samsung TV with Tizen OS, and hls-js for video handle
  2. Script referenced as hls-js@latest [now it is v0.13.0]
  3. Hls.isSupported() throws an error [Can't find variable: SourceBuffer]

Expected behavior

Hls.isSupported() needs to return true or false.

Actual behavior

Hls.isSupported() is throwing error [Can't find variable: SourceBuffer]
@robwalch
Copy link
Collaborator

Samsung TV with Tizen OS

Which device models? Series 6, 7... 2016, 2017...?

@riadasllani
Copy link
Author

I have been testing, with some TVs. And here are two models that happens the same problem.

  1. Samsung SmartTV
  • Model Code: UE50J6240
  • Software Version: T-HKMFDEUC-1530.1
  • Produced in 2015
  1. Samsung SmartTV
  • Model Code: UE40NU7192PD
  • Poduced in 2018

If it is needed more information I will happily provide.

@stuartflanagan
Copy link

I have the same problem with Tizen2017 model.
The TV plays back HLS without HLS.JS but I am trying to get webvtt embedded captions displaying as they are not displaying when using the regular

@robwalch
Copy link
Collaborator

robwalch commented Jan 3, 2020 •
edited

Thanks for the additional info. I'm closing this issue and marking it as a duplicate. This will be fixed promptly in v0.13.1 as it's very easy to reproduce in older versions of Chrome.

@robwalch robwalch added Bug and removed Need info labels Jan 3, 2020
@robwalch robwalch added this to the 0.13.1 milestone Jan 3, 2020
@robwalch
Copy link
Collaborator

robwalch commented Jan 3, 2020

Duplicates #2430

@robwalch robwalch closed this as completed Jan 3, 2020
robwalch pushed a commit to jwplayer/hls.js that referenced this issue Jan 3, 2020
Fix isSupported check in browser missing SourceBuffer global
ff6320b 
Fixes video-dev#2430 video-dev#2476
@robwalch robwalch mentioned this issue Jan 3, 2020
Merged
1 task
@stuartflanagan
Copy link

Sorry for this question but we are doing some release planning as well. Just wondering what your timeline is for the release of 0.13.1 ? Thanks for addressing this so quickly.

@stuartflanagan
Copy link

@robwalch ah I see there is a canary build.
I will test the app out on that. Thank you!

@stuartflanagan
Copy link

Must not be in the canary build as yet.

@robwalch
Copy link
Collaborator

robwalch commented Jan 6, 2020

@stuartflanagan The fix is included in the latest release which is available now.

https://github.com/video-dev/hls.js/releases/tag/v0.13.1

@stuartflanagan
Copy link

Thank you @robwalch

robwalch pushed a commit that referenced this issue Jan 8, 2020
Merge branch 'upstream/master' into feature/v1.0.0
06e48aa 
* upstream/master: (92 commits)
  Update package-lock
  Update TypeScript and run `npm audit fix`
  Add a lint rule to disallow use of SourceBuffer global
  Fix `isSupported` check in browser missing `SourceBuffer` global Fixes #2430 #2476
  https
  add code of conduct
  Remove build:types from release job.
  Remove TypeScript types build step
  only include js files in release
  Prevent seeking to 0 when startPosition is -1 Fixes #2438
  Prevent RangeError exception when parsing incomplete PES Fixes #2415 Relates to #2109
  Log license key size (DRM functional test troubleshooting)
  Improve functional test assertion feedback
  Handle stalls when seeking into buffer gaps
  Update gap controller to observe buffer gaps regardless of max buffer hole
  Update gap-controller comments
  Add seek back to start functional test
  Fix start gap jumping with partial fragments and when seeking back to start
  Reset stall time after seeked and fix logger statments
  Fix partial and large start gap jumping
  ...

# Conflicts:
#	package-lock.json
#	package.json
#	scripts/travis.sh
#	src/controller/audio-stream-controller.js
#	src/controller/buffer-controller.ts
#	src/controller/gap-controller.js
#	src/controller/id3-track-controller.js
#	src/controller/stream-controller.js
#	src/controller/subtitle-stream-controller.ts
#	src/controller/subtitle-track-controller.ts
#	src/controller/timeline-controller.ts
#	src/demux/tsdemuxer.ts
#	src/events.js
#	src/loader/m3u8-parser.ts
#	src/utils/buffer-helper.ts
#	tests/functional/auto/setup.js
#	tests/test-streams.js
#	tests/unit/controller/ewma-bandwidth-estimator.js
#	tests/unit/controller/gap-controller.js
#	tests/unit/controller/subtitle-stream-controller.js
robwalch pushed a commit to jwplayer/hls.js that referenced this issue Jan 8, 2020
Merge branch 'feature/v1.0.0' into bugfix/dts-sync
9232089 
* feature/v1.0.0: (95 commits)
  Enforce no-case-declarations
  Cleanup timeout calls
  Enforce 'no-unused-vars' lint rule
  Update package-lock
  Update TypeScript and run `npm audit fix`
  Add a lint rule to disallow use of SourceBuffer global
  Fix `isSupported` check in browser missing `SourceBuffer` global Fixes video-dev#2430 video-dev#2476
  https
  add code of conduct
  Remove build:types from release job.
  Remove TypeScript types build step
  only include js files in release
  Prevent seeking to 0 when startPosition is -1 Fixes video-dev#2438
  Prevent RangeError exception when parsing incomplete PES Fixes video-dev#2415 Relates to video-dev#2109
  Log license key size (DRM functional test troubleshooting)
  Improve functional test assertion feedback
  Handle stalls when seeking into buffer gaps
  Update gap controller to observe buffer gaps regardless of max buffer hole
  Update gap-controller comments
  Add seek back to start functional test
  ...
robwalch pushed a commit to jwplayer/hls.js that referenced this issue Jan 9, 2020
Merge branch 'feature/v1.0.0' into LHLS
a8f1a7e 
* feature/v1.0.0: (96 commits)
  Fix audio gaps introduced by changes in remuxer continuity tracking
  Enforce no-case-declarations
  Cleanup timeout calls
  Enforce 'no-unused-vars' lint rule
  Update package-lock
  Update TypeScript and run `npm audit fix`
  Add a lint rule to disallow use of SourceBuffer global
  Fix `isSupported` check in browser missing `SourceBuffer` global Fixes video-dev#2430 video-dev#2476
  https
  add code of conduct
  Remove build:types from release job.
  Remove TypeScript types build step
  only include js files in release
  Prevent seeking to 0 when startPosition is -1 Fixes video-dev#2438
  Prevent RangeError exception when parsing incomplete PES Fixes video-dev#2415 Relates to video-dev#2109
  Log license key size (DRM functional test troubleshooting)
  Improve functional test assertion feedback
  Handle stalls when seeking into buffer gaps
  Update gap controller to observe buffer gaps regardless of max buffer hole
  Update gap-controller comments
  ...
@snyk-bot snyk-bot mentioned this issue Mar 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Duplicate
Projects
None yet
Milestone
0.13.1
Development

Successfully merging a pull request may close this issue.

Fix isSupported check in browsers missing SourceBuffer global video-dev/hls.js
3 participants
@robwalch @stuartflanagan @riadasllani