Fix isSupported check in browsers missing SourceBuffer global
#2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjenkinson
previously approved these changes
Jan 3, 2020
src/is-supported.ts
Outdated
| @@ -5,7 +5,7 @@ export function isSupported (): boolean { | |||
| if (!mediaSource) { | |||
| return false; | |||
| } | |||
| const sourceBuffer = SourceBuffer || (window as any).WebKitSourceBuffer; | |||
| const sourceBuffer = (self as any).SourceBuffer || (self as any).WebKitSourceBuffer as SourceBuffer; | |||
There was a problem hiding this comment.
Suggested change
| const sourceBuffer = (self as any).SourceBuffer || (self as any).WebKitSourceBuffer as SourceBuffer; | |
| const sourceBuffer = self.SourceBuffer || (self as any).WebKitSourceBuffer as SourceBuffer; |
self.SourceBuffer already has the correct type
There was a problem hiding this comment.
Requires a TypeScript update (done 2c4f7e6). I was getting this error and went for the easy fix instead of updating deps.
$ npm run type-check
> tsc --noEmit
src/is-supported.ts:8:29 - error TS2339: Property 'SourceBuffer' does not exist on type 'Window'.
8 const sourceBuffer = self.SourceBuffer || (self as any).WebKitSourceBuffer as SourceBuffer;
There was a problem hiding this comment.
Oh maybe. I just checked locally in vscode and it had the types. If it doesn’t cause any issues I think keeping typescript up to date makes sense
| @@ -76,6 +76,13 @@ module.exports = { | |||
| 'never' | |||
| ], | |||
|
|
|||
| 'no-restricted-globals': [2, | |||
| { | |||
| 'name': 'SourceBuffer', | |||
itsjamie
previously approved these changes
Jan 4, 2020
tjenkinson
approved these changes
Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
isSupportedcheck in browsers missingSourceBufferglobal.SourceBufferglobal usage.npm audit fixWhy is this Pull Request needed?
JavaScript... no exceptions.
Are there any points in the code the reviewer needs to double check?
No
Resolves issues:
resolves #2430
resolves #2476
Checklist