Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for IE11 missing Number.MAX_SAFE_INTEGER #2891

Merged
merged 1 commit into from Jul 14, 2020
Merged

Fix for IE11 missing Number.MAX_SAFE_INTEGER #2891

merged 1 commit into from Jul 14, 2020

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jul 14, 2020 •
edited

This PR will...

  • Replace Number.MAX_SAFE_INTEGER with an import the same way we replace Number.isFinite for IE11.
  • Use Number.POSITIVE_INFINITY and Number.NEGATIVE_INFINITY for default min/max values in remuxVideo.
  • Cleanup use of inputSamples.length in remuxVideo

Why is this Pull Request needed?

Fixes playback on IE11.

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch requested a review from itsjamie July 14, 2020 22:47
@robwalch robwalch added this to the 0.14.2 milestone Jul 14, 2020
@robwalch robwalch merged commit 397c6a5 into master Jul 14, 2020
@robwalch robwalch deleted the bugfix/ie11-number branch July 14, 2020 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsjamie itsjamie Awaiting requested review from itsjamie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@robwalch