Fix demuxer switching on level switch and discontinuities #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Probe segments in order of transmux configs on discontinuities and track switch, to avoid false positives when existing AAC demuxer probes TS files.
Maintain the same demuxer and remuxer as long as the type hasn't changed.
Why is this Pull Request needed?
DAI inserts TS audio segments in audio tracks with AAC segments, and
AACDemuxer.probereturnstruewhen passed the TS data.Throwing away the remuxer when the audio demuxer changes drops audio because the last appended timecode is lost.
Resolves issues:
#2887
Checklist