Functional test improvements & test failure investigation #2921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
onprogress
if more than 2buffered
ranges are found (If have an unexpected gap, the test should fail)Why is this Pull Request needed?
Improve test run stability required and optional browser configurations.
Other notes
This PR was originally for troubleshooting test failures that I was having difficulty reproducing locally. If you're interested in the temporary changes I made to troubleshoot test runs both locally and in the travis runs, let me know and I can move the stashed changes into a branch. Disabling the worker and shortening the list of test stream to the problem stream are the first steps.
When
should seek 5s from end and receive video ended event for Multiple non-alternate audio levels
times out, it appears to be doing more buffering than necessary before seeking. This seems to be an edge-case related to the media containing mixed AAC/HE-AAC media playlists or the mixed samplerates of 24/48kHz. The audio buffer is initialized with the 24kHz audio and then when the 48kHz audio is appended its samples are still treated as 24kHz. In other tests where we don't seek again getting the stream loader stuck in a loop, appending a segment whose sample start *2 exceeds the duration produces media-decode-error (3).So close to 100% on Firefox!
https://travis-ci.org/github/video-dev/hls.js/jobs/711630371
I haven't been able to reproduce this locally in the demo, but I can running
test unit:func
.In troubleshooting I found that we request both
startLoad
and buffer flushing twice; This should be fixed in feature/v1.0.0, but addressing these here did not prevent the sample rate buffer offset or decode error issues. 馃槗The next step would be to look at the differences between the test run and demo. When commenting out
browser.quit()
and checkingchrome://media-internals/
shows the following:Related issues:
#2837
Checklist